From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbeFANTm (ORCPT ); Fri, 1 Jun 2018 09:19:42 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:49038 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbeFANTl (ORCPT ); Fri, 1 Jun 2018 09:19:41 -0400 From: Colin King To: Jean Delvare Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] firmware-gsmi: make structure gsmi_dev static Date: Fri, 1 Jun 2018 14:19:39 +0100 Message-Id: <20180601131939.4959-1-colin.king@canonical.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The structure gsmi_dev is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: drivers/firmware/google/gsmi.c:96:3: warning: symbol 'gsmi_dev' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/firmware/google/gsmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c index c8f169bf2e27..734146eec1b9 100644 --- a/drivers/firmware/google/gsmi.c +++ b/drivers/firmware/google/gsmi.c @@ -84,7 +84,7 @@ struct gsmi_buf { u32 address; /* physical address of buffer */ }; -struct gsmi_device { +static struct gsmi_device { struct platform_device *pdev; /* platform device */ struct gsmi_buf *name_buf; /* variable name buffer */ struct gsmi_buf *data_buf; /* generic data buffer */ -- 2.17.0