mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Peter Zijlstra <peterz@infradead.org>, Petr Mladek <pmladek@suse.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
	linux-kernel@vger.kernel.org, alek.du@intel.com,
	pasha.tatashin@oracle.com, arjan@linux.intel.com
Subject: Re: [RFC 2/2] x86, tsc: Enable clock for ealry printk timestamp
Date: Sat, 2 Jun 2018 00:12:13 +0800	[thread overview]
Message-ID: <20180601161213.tm44nhrhwfxa2767@shbuild888> (raw)
In-Reply-To: <20180531155210.GL12180@hirez.programming.kicks-ass.net>

Hi Peter and Petr,

Thanks for your suggestions, will try to find a cleaner and less hacky way,
and it may take some time as dealing with all kinds of TSC is tricky :)

- Feng

On Thu, May 31, 2018 at 05:52:10PM +0200, Peter Zijlstra wrote:
> On Thu, May 31, 2018 at 03:55:42PM +0200, Petr Mladek wrote:
> > I wonder if we could get some cleaner integration into the timer and
> > printk code.
> 
> Yes, these patches are particularly horrific..
> 
> There were some earlier patches by Pavel Tatashin, which attempted do
> get things running earlier.
> 
>   http://lkml.kernel.org/r/20180209211143.16215-1-pasha.tatashin@oracle.com
> 
> I'm not entirely happy with that, but I never did get around to
> reviewing that last version :-( In particuarly, now that you made me
> look, I dislike his patch 6 almost as much as these patches.
> 
> The idea was to get regular sched_clock() running earlier, not to botch
> some early_sched_clock() into it.
> 
> Basically run calibrate_tsc() earlier (like _waaay_ earlier, it doesn't
> rely on anything other than CPUID) and if you have a recent part (with
> exception of SKX) you'll get a usable tsc rate (and TSC_RELIABLE) and
> things will work.
> 
> If you have a dodgy part (sorry SKX), you'll just have to live with
> sched_clock starting late(r).
> 
> Do not cobble things on the side, try and get the normal things running
> earlier.

  reply	other threads:[~2018-06-01 16:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  9:20 [RFC 1/2] printk: Enable platform to provide a early boot clock Feng Tang
2018-05-30  9:20 ` [RFC 2/2] x86, tsc: Enable clock for ealry printk timestamp Feng Tang
2018-05-30 13:25   ` Andy Shevchenko
2018-05-30 14:17     ` Feng Tang
2018-05-31 13:55   ` Petr Mladek
2018-05-31 15:52     ` Peter Zijlstra
2018-06-01 16:12       ` Feng Tang [this message]
2018-06-06  9:38         ` Feng Tang
2018-06-06 15:25           ` Pavel Tatashin
2018-06-07  1:34             ` Feng Tang
2018-06-13  7:29           ` Feng Tang
2018-06-01 18:05       ` Pavel Tatashin
2018-05-31  7:18 ` [RFC 1/2] printk: Enable platform to provide a early boot clock Andy Shevchenko
2018-05-31 17:22   ` Randy Dunlap
2018-05-31 18:15     ` Andy Shevchenko
2018-06-14  8:38 ` Feng Tang
2018-06-14  9:08   ` Thomas Gleixner
2018-06-14  9:55     ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180601161213.tm44nhrhwfxa2767@shbuild888 \
    --to=feng.tang@intel.com \
    --cc=alek.du@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pasha.tatashin@oracle.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®