From: Nick Desaulniers <ndesaulniers@google.com>
To: akpm@linux-foundation.org, ard.biesheuvel@linaro.org,
aryabinin@virtuozzo.com, akataria@vmware.com,
boris.ostrovsky@oracle.com, brijesh.singh@amd.com,
caoj.fnst@cn.fujitsu.com, gregkh@linuxfoundation.org,
hpa@zytor.com, jan.kiszka@siemens.com,
jarkko.sakkinen@linux.intel.com, jgross@suse.com,
jpoimboe@redhat.com, kirill.shutemov@linux.intel.com,
mingo@redhat.com, mjg59@google.com, mka@chromium.org,
ndesaulniers@google.com, pombredanne@nexb.com,
rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com,
tweek@google.com
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, virtualization@lists.linux-foundation.org
Subject: [PATCH 0/3] extern inline native_save_fl for paravirt
Date: Fri, 1 Jun 2018 09:55:47 -0700 [thread overview]
Message-ID: <20180601165550.90053-1-ndesaulniers@google.com> (raw)
paravirt depends on a custom calling convention (callee saved), but
expects this from a static inline function that it then forces to be
outlined. This is problematic because different compilers or flags can
then add a stack guard that violates the calling conventions.
Uses extern inline with the out-of-line definition in assembly to
prevent compilers from adding stack guards to the outlined version.
Other parts of the codebase overwrite KBUILD_CFLAGS, which is *extremely
problematic* for extern inline, as the sematics are completely the
opposite depending on what C standard is used.
http://blahg.josefsipek.net/?p=529
Nick Desaulniers (3):
efi: use -std=gnu89 for proper extern inline semantics
x86/build: use -std=gnu89 for proper extern inline semantics
x86: paravirt: make native_save_fl extern inline
arch/x86/boot/compressed/Makefile | 2 +-
arch/x86/include/asm/irqflags.h | 2 +-
arch/x86/kernel/Makefile | 1 +
arch/x86/kernel/irqflags.S | 26 ++++++++++++++++++++++++++
drivers/firmware/efi/libstub/Makefile | 2 +-
5 files changed, 30 insertions(+), 3 deletions(-)
create mode 100644 arch/x86/kernel/irqflags.S
--
2.17.0.921.gf22659ad46-goog
next reply other threads:[~2018-06-01 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:55 Nick Desaulniers [this message]
2018-06-01 16:55 ` [PATCH 1/3] efi: use -std=gnu89 for proper extern inline semantics Nick Desaulniers
2018-06-01 16:55 ` [PATCH 2/3] x86/build: " Nick Desaulniers
2018-06-01 17:36 ` hpa
2018-06-01 16:55 ` [PATCH 3/3] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601165550.90053-1-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=aryabinin@virtuozzo.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjg59@google.com \
--cc=mka@chromium.org \
--cc=pombredanne@nexb.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®