From: Michal Hocko <mhocko@kernel.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
tgraf@suug.ch, herbert@gondor.apana.org.au,
manfred@colorfullife.com,
guillaume.knispel@supersonicimagine.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 2/5] lib/rhashtable: guarantee initial hashtable allocation
Date: Mon, 4 Jun 2018 13:46:22 +0200 [thread overview]
Message-ID: <20180604114622.GK19202@dhcp22.suse.cz> (raw)
In-Reply-To: <20180601160125.30031-3-dave@stgolabs.net>
On Fri 01-06-18 09:01:22, Davidlohr Bueso wrote:
[...]
> diff --git a/lib/rhashtable.c b/lib/rhashtable.c
> index 05a4b1b8b8ce..ae17da6f0c75 100644
> --- a/lib/rhashtable.c
> +++ b/lib/rhashtable.c
> @@ -175,7 +175,7 @@ static struct bucket_table *bucket_table_alloc(struct rhashtable *ht,
> int i;
>
> size = sizeof(*tbl) + nbuckets * sizeof(tbl->buckets[0]);
> - if (gfp != GFP_KERNEL)
> + if ((gfp & ~__GFP_NOFAIL) != GFP_KERNEL)
> tbl = kzalloc(size, gfp | __GFP_NOWARN | __GFP_NORETRY);
> else
> tbl = kvzalloc(size, gfp);
Just a heads up. This is not longer needed after
http://lkml.kernel.org/r/20180601115329.27807-1-mhocko@kernel.org
is applied. Moreover it will conflict at that spot.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-06-04 11:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:01 [PATCH -next v2 0/5] rhashtable: guarantee first allocation Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 1/5] lib/rhashtable: convert param sanitations to WARN_ON Davidlohr Bueso
2018-06-01 16:09 ` Herbert Xu
2018-06-01 16:53 ` Davidlohr Bueso
2018-06-01 16:59 ` Herbert Xu
2018-06-01 17:10 ` Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 2/5] lib/rhashtable: guarantee initial hashtable allocation Davidlohr Bueso
2018-06-02 4:41 ` Herbert Xu
2018-06-02 5:41 ` Davidlohr Bueso
2018-06-02 15:53 ` Herbert Xu
2018-06-04 11:46 ` Michal Hocko [this message]
2018-06-01 16:01 ` [PATCH 3/5] ipc: get rid of ids->tables_initialized hack Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 4/5] ipc: simplify ipc initialization Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 5/5] lib/test_rhashtable: rhashtable_init() can no longer fail Davidlohr Bueso
2018-06-02 4:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604114622.GK19202@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=guillaume.knispel@supersonicimagine.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=tgraf@suug.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®