From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbeFDTE3 (ORCPT ); Mon, 4 Jun 2018 15:04:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35864 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751213AbeFDTE1 (ORCPT ); Mon, 4 Jun 2018 15:04:27 -0400 Date: Mon, 4 Jun 2018 14:04:25 -0500 From: Josh Poimboeuf To: Nadav Amit Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Christopher Li , linux-sparse@vger.kernel.org Subject: Re: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions Message-ID: <20180604190425.iam6ik5zrjf4wk6v@treble> References: <20180604112131.59100-1-namit@vmware.com> <20180604112131.59100-3-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180604112131.59100-3-namit@vmware.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 04, 2018 at 04:21:24AM -0700, Nadav Amit wrote: > +#ifdef CONFIG_STACK_VALIDATION > +.macro ANNOTATE_UNREACHABLE counter:req > +\counter: > + .pushsection .discard.unreachable > + .long \counter\()b -. > + .popsection > +.endm > + > +.macro ANNOTATE_REACHABLE counter:req > +\counter: > + .pushsection .discard.reachable > + .long \counter\()b -. > + .popsection > +.endm > + > +.macro ASM_UNREACHABLE > +999: > + .pushsection .discard.unreachable > + .long 999b - . > + .popsection > +.endm > +#else /* CONFIG_STACK_VALIDATION */ > +.macro ANNOTATE_UNREACHABLE counter:req > +.endm > + > +.macro ANNOTATE_UNREACHABLE counter:req > +.endm > + > +.macro ASM_UNREACHABLE > +.endm /* CONFIG_STACK_VALIDATION */ > +#endif The '/* CONFIG_STACK_VALIDATION */' comment is on the wrong line. Otherwise: Reviewed-by: Josh Poimboeuf -- Josh