From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752554AbeFEWWm (ORCPT ); Tue, 5 Jun 2018 18:22:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:34478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbeFEWWl (ORCPT ); Tue, 5 Jun 2018 18:22:41 -0400 Date: Tue, 5 Jun 2018 17:21:59 -0500 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Oza Pawandeep , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/2] PCI/AER: Clean up minor logging issues Message-ID: <20180605222158.GD226399@bhelgaas-glaptop.roam.corp.google.com> References: <152770259826.80701.7360032106128917833.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152770259826.80701.7360032106128917833.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 12:54:10PM -0500, Bjorn Helgaas wrote: > AER logging printed the plain 16-bit Requester ID straight out of the TLP, > which is hard to interpret, e.g., id=00e4 corresponds to what we normally > see as 00:1c.4 in dmesg or lspci. > > Also, there's no need to print the vendor/device ID of the root port > reporting an error; we can easily find that from dmesg or lspci. > > --- > > Bjorn Helgaas (2): > PCI/AER: Decode Error Source Requester ID > PCI/AER: Stop printing vendor/device ID > > > drivers/pci/pcie/aer/aerdrv_errprint.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) I applied the first but not the second to pci/aer for v4.18.