From: Masatake YAMATO <yamato@redhat.com>
To: tglx@linutronix.de
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, joro@8bytes.org
Subject: Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
Date: Wed, 06 Jun 2018 20:15:29 +0900 (JST) [thread overview]
Message-ID: <20180606.201529.867663362891798169.yamato@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1806061235330.1579@nanos.tec.linutronix.de>
On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
>
> Can you please explain why 0 is the wrong value.
I don't know such constants, 0 and 1.
What I change is just the name of macro parameter as
s/detect/_detect/
I don't change the definition of macro.
Masatake YAMATO
> That's not a typo, that's
> a functional change and both the subject line and the changelog itself
> should be explanatory.
>
> Thanks,
>
> tglx
>
>> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
>> ---
>> arch/x86/include/asm/iommu_table.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
>> index 1fb3fd1a83c2..2a0d5f7d1ed1 100644
>> --- a/arch/x86/include/asm/iommu_table.h
>> +++ b/arch/x86/include/asm/iommu_table.h
>> @@ -66,7 +66,7 @@ struct iommu_table_entry {
>> #define IOMMU_INIT_POST(_detect) \
>> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0)
>>
>> -#define IOMMU_INIT_POST_FINISH(detect) \
>> +#define IOMMU_INIT_POST_FINISH(_detect) \
>> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)
>>
>> /*
>> --
>> 2.17.0
>>
>>
next prev parent reply other threads:[~2018-06-06 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 5:10 Masatake YAMATO
2018-06-06 10:37 ` Thomas Gleixner
2018-06-06 11:15 ` Masatake YAMATO [this message]
2018-06-06 12:10 ` Thomas Gleixner
2018-06-06 12:41 ` Thomas Gleixner
2018-06-06 14:03 ` Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606.201529.867663362891798169.yamato@redhat.com \
--to=yamato@redhat.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®