From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 327EE601A8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932394AbeFFP4g (ORCPT + 25 others); Wed, 6 Jun 2018 11:56:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:42049 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932212AbeFFP4f (ORCPT ); Wed, 6 Jun 2018 11:56:35 -0400 Date: Wed, 6 Jun 2018 17:53:47 +0200 From: David Sterba To: Souptick Joarder Cc: willy@infradead.org, clm@fb.com, jbacik@fb.com, dsterba@suse.com, dsterba@suse.cz, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs: btrfs: Change return type to vm_fault_t Message-ID: <20180606155347.GL3539@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Souptick Joarder , willy@infradead.org, clm@fb.com, jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180606142444.GA3806@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180606142444.GA3806@jordon-HP-15-Notebook-PC> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 06, 2018 at 07:54:44PM +0530, Souptick Joarder wrote: > @@ -9009,7 +9007,7 @@ int btrfs_page_mkwrite(struct vm_fault *vmf) > unlock_extent_cached(io_tree, page_start, page_end, &cached_state); > > out_unlock: > - if (!ret) { > + if (!ret2) { > btrfs_delalloc_release_extents(BTRFS_I(inode), PAGE_SIZE, true); > sb_end_pagefault(inode->i_sb); > extent_changeset_free(data_reserved); 9013 return VM_FAULT_LOCKED; 9014 } 9015 unlock_page(page); 9016 out: 9017 btrfs_delalloc_release_extents(BTRFS_I(inode), PAGE_SIZE, (ret != 0)); 9018 btrfs_delalloc_release_space(inode, data_reserved, page_start, 9019 reserved_space, (ret != 0)); I've noticed that there's 'ret' used on lines 9017 and 19, comparing to a raw number. Is this going to be ok once vm_fault_t is it's own type? There's no corresponding define for 0 among the VM_FAULT_* values, I'd expect 0 to work interchangeably, similar to the blk_status_t type: https://elixir.bootlin.com/linux/latest/source/include/linux/blk_types.h#L30 #define BLK_STS_OK 0 #define BLK_STS_NOTSUPP ((__force blk_status_t)1) #define BLK_STS_TIMEOUT ((__force blk_status_t)2) #define BLK_STS_NOSPC ((__force blk_status_t)3) ... Your patch is otherwise ok, I'm just curious if this is something to watch for once vmfault type is switched.