From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org by pdx-caf-mail.web.codeaurora.org (Dovecot) with LMTP id Xo8NLNTkGFudKAAAmS7hNA ; Thu, 07 Jun 2018 07:55:00 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9FF09608B8; Thu, 7 Jun 2018 07:55:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by smtp.codeaurora.org (Postfix) with ESMTP id 2DF8660452; Thu, 7 Jun 2018 07:55:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2DF8660452 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbeFGHyz (ORCPT + 25 others); Thu, 7 Jun 2018 03:54:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47004 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752881AbeFGHyx (ORCPT ); Thu, 7 Jun 2018 03:54:53 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F35B7401EF1C; Thu, 7 Jun 2018 07:54:52 +0000 (UTC) Received: from plouf.banquise.eu.com (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65BC12026DEF; Thu, 7 Jun 2018 07:54:51 +0000 (UTC) From: Benjamin Tissoires To: Jiri Kosina , Dmitry Torokhov Cc: Mario.Limonciello@dell.com, Peter Hutterer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires Subject: [PATCH v2 00/13] Hid multitouch rewrite, support os system multi-axis devices, take 2 Date: Thu, 7 Jun 2018 09:54:35 +0200 Message-Id: <20180607075448.5706-1-benjamin.tissoires@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 07 Jun 2018 07:54:53 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Thu, 07 Jun 2018 07:54:53 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'benjamin.tissoires@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a new version of my previous series with few improvements. I also merged the patches Dmitry sent out last year regarding the MT_TOOL_PALM. Dmitry, I kept your SoB lines, feel free to yell if there is something wrong. Compared to the previous series some highlights: - no more changes in input-core (behavior changes I mean) - I split out the creation of MT_TOOL_DIAL - I also fixed the location of MT_TOOL_* declaration in the uapi - the Totem now has a hint that it will be reporting MT_TOOL_DIAL (setting the min/max to MT_TOOL_DIAL tells userspace that this is the only possible value) - MT_TOOL_PALM changes from Dmitry are integrated. Regarding the last item, we had a discussion whether or not quirking the devices. After some brainstorming Peter and I came to a possible explanation on why Dmitry was the only one detecting those issues. I never had a report of a Win8 touchscreen that does palm rejection. And if you think of it, when you use a touchscreen, you carefully place your hand so it doesn't rest on the surface. Well, things are different with dual sensors like Wacom devices. You can expect the user to rest his/her palm on the surface while holding the pen (or your writing gets all wobbly which kills the purpose). So if Wacom or Pen+touch devices are the only ones having palm rejection, in the libinput/Xorg world, the userspace tablet driver ends up doing palm rejection for us if it's not already filtered out by the kernel. I am not sure about how ChromeOS or Android handle such situations, but there is a chance this is what the ChromeOS team was experiencing. Given that assumption, I think we are safer to just keep the workaround for all devices, knowing that it will only be triggered for a few devices. Cheers, Benjamin Benjamin Tissoires (13): input: move MT_TOOL_* to input-event-codes.h input: add MT_TOOL_DIAL HID: multitouch: make sure the static list of class is not changed HID: multitouch: Store per collection multitouch data HID: multitouch: store a per application quirks value HID: multitouch: ditch mt_report_id HID: multitouch: remove one copy of values HID: input: enable Totem on the Dell Canvas 27 HID: core: do not upper bound the collection stack HID: microsoft: support the Surface Dial HID: multitouch: report MT_TOOL_PALM for non-confident touches HID: multitouch: touchscreens also use confidence reports HID: multitouch: handle palm for touchscreens Documentation/input/multi-touch-protocol.rst | 12 +- drivers/hid/hid-core.c | 17 +- drivers/hid/hid-input.c | 3 + drivers/hid/hid-microsoft.c | 49 +- drivers/hid/hid-multitouch.c | 996 ++++++++++++++++----------- include/linux/hid.h | 15 +- include/uapi/linux/input-event-codes.h | 9 + include/uapi/linux/input.h | 8 - 8 files changed, 691 insertions(+), 418 deletions(-) -- 2.14.3