From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org, oleg@redhat.com, gkohli@codeaurora.org
Cc: tglx@linutronix.de, mpe@ellerman.id.au, bigeasy@linutronix.de,
linux-kernel@vger.kernel.org, will.deacon@arm.com
Subject: Re: [PATCH 2/4] watchdog/softlockup: Replace "watchdog/%u" threads with cpu_stop_work
Date: Thu, 7 Jun 2018 16:24:05 +0200 [thread overview]
Message-ID: <20180607142405.GO12198@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180607124006.158330973@infradead.org>
On Thu, Jun 07, 2018 at 02:33:12PM +0200, Peter Zijlstra wrote:
> +static int softlockup_stop_fn(void *data)
> {
> + watchdog_disable(smp_processor_id());
> + return 0;
> }
>
> +static void softlockup_stop_all(void)
> {
> + int cpu;
> +
> + for_each_cpu(cpu, &watchdog_allowed_mask)
> + stop_one_cpu(cpu, softlockup_stop_fn, NULL);
> +
> + cpumask_clear(&watchdog_allowed_mask);
> }
Bugger, that one doesn't quite work.. watchdog_disable() ends up calling
a sleeping function. I forgot to enable all the debug cruft when
testing..
Let me try and fix that..
next prev parent reply other threads:[~2018-06-07 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 12:33 [PATCH 0/4] kthread/smpboot: More fixes Peter Zijlstra
2018-06-07 12:33 ` [PATCH 1/4] kthread, sched: Fix kthread_parkme() (again...) Peter Zijlstra
2018-06-07 12:33 ` [PATCH 2/4] watchdog/softlockup: Replace "watchdog/%u" threads with cpu_stop_work Peter Zijlstra
2018-06-07 14:24 ` Peter Zijlstra [this message]
2018-06-07 14:42 ` Peter Zijlstra
2018-06-08 13:57 ` Oleg Nesterov
2018-06-12 12:17 ` Peter Zijlstra
2018-06-07 12:33 ` [PATCH 3/4] smpboot: Remove cpumask from the API Peter Zijlstra
2018-06-07 12:33 ` [PATCH 4/4] kthread: Simplify kthread_park() completion Peter Zijlstra
2018-06-08 9:52 ` Oleg Nesterov
2018-06-12 12:42 ` Peter Zijlstra
2018-06-25 7:12 ` Peter Zijlstra
2018-06-25 16:53 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607142405.GO12198@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=gkohli@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome