From: Brandon Maier <brandon.maier@rockwellcollins.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
michal.simek@xilinx.com, clayton.shotwell@rockwellcollins.com,
kristopher.cory@rockwellcollins.com,
linux-kernel@vger.kernel.org,
Brandon Maier <brandon.maier@rockwellcollins.com>
Subject: [PATCH 3/3] net: phy: xgmiitorgmii: Check read_status results
Date: Thu, 7 Jun 2018 10:53:48 -0500 [thread overview]
Message-ID: <20180607155348.149665-3-brandon.maier@rockwellcollins.com> (raw)
In-Reply-To: <20180607155348.149665-1-brandon.maier@rockwellcollins.com>
We're ignoring the result of the attached phy device's read_status().
Return it so we can detect errors.
Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
---
drivers/net/phy/xilinx_gmii2rgmii.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index d6f8b64cddbe..74a8782313cf 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -42,8 +42,11 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
struct mii_bus *bus = priv->mdio->bus;
int addr = priv->mdio->addr;
u16 val = 0;
+ int err;
- priv->phy_drv->read_status(phydev);
+ err = priv->phy_drv->read_status(phydev);
+ if (err < 0)
+ return err;
val = mdiobus_read(bus, addr, XILINX_GMII2RGMII_REG);
val &= ~XILINX_GMII2RGMII_SPEED_MASK;
--
2.14.3
next prev parent reply other threads:[~2018-06-07 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 15:53 [PATCH 1/3] net: phy: Check phy_driver ready before accessing Brandon Maier
2018-06-07 15:53 ` [PATCH 2/3] net: phy: xgmiitorgmii: Use correct mdio bus Brandon Maier
2018-06-07 16:49 ` Andrew Lunn
2018-06-07 17:37 ` Brandon Maier
2018-06-07 15:53 ` Brandon Maier [this message]
2018-06-07 16:43 ` [PATCH 3/3] net: phy: xgmiitorgmii: Check read_status results Andrew Lunn
2018-06-07 16:52 ` [PATCH 1/3] net: phy: Check phy_driver ready before accessing Andrew Lunn
2018-06-07 17:34 ` Brandon Maier
2018-06-07 18:12 ` Andrew Lunn
2018-06-07 16:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607155348.149665-3-brandon.maier@rockwellcollins.com \
--to=brandon.maier@rockwellcollins.com \
--cc=andrew@lunn.ch \
--cc=clayton.shotwell@rockwellcollins.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kristopher.cory@rockwellcollins.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®