From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 9C412C004E4 for ; Mon, 11 Jun 2018 21:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B3362086D for ; Mon, 11 Jun 2018 21:20:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B3362086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933925AbeFKVUK (ORCPT ); Mon, 11 Jun 2018 17:20:10 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:56258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932395AbeFKVUG (ORCPT ); Mon, 11 Jun 2018 17:20:06 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 29B561015159A; Mon, 11 Jun 2018 14:20:06 -0700 (PDT) Date: Mon, 11 Jun 2018 14:20:05 -0700 (PDT) Message-Id: <20180611.142005.1712154808921112617.davem@davemloft.net> To: jiazhouyang09@gmail.com Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: add error handling for pskb_trim_rcsum From: David Miller In-Reply-To: <1528694795-32000-1-git-send-email-jiazhouyang09@gmail.com> References: <1528694795-32000-1-git-send-email-jiazhouyang09@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Jun 2018 14:20:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhouyang Jia Date: Mon, 11 Jun 2018 13:26:35 +0800 > When pskb_trim_rcsum fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling pskb_trim_rcsum. > > Signed-off-by: Zhouyang Jia Applied and queued up for -stable, thanks.