From: Peter Zijlstra <peterz@infradead.org>
To: Nadav Amit <namit@vmware.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v3 4/9] x86: alternatives: macrofy locks for better inlining
Date: Mon, 11 Jun 2018 10:03:14 +0200 [thread overview]
Message-ID: <20180611080314.GR12258@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180610141911.52948-5-namit@vmware.com>
On Sun, Jun 10, 2018 at 07:19:06AM -0700, Nadav Amit wrote:
> #ifdef CONFIG_SMP
> +.macro LOCK_PREFIX_HERE
> .pushsection .smp_locks,"a"
> .balign 4
> + .long 671f - . # offset
> .popsection
> +671:
> +.endm
> +
> +.macro LOCK_PREFIX insn:vararg
> + LOCK_PREFIX_HERE
> + lock \insn
> +.endm
Hurmph, the only reason we need to preserve that LOCK_PREFIX_HERE thing
is arch_cmpxchg64 in cmpxchg_32.h. Is there really no other way we can
write that one?
I suppose the problem with using LOCK_PREFIX inside the alternative is
that the .smp_locks fixup address gets computed wrong (inside the
alternative_text section instead of in the regular text)?
Oh well..
next prev parent reply other threads:[~2018-06-11 8:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 14:19 [PATCH v3 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-06-10 14:19 ` [PATCH v3 1/9] Makefile: Prepare for using macros for inline asm Nadav Amit
2018-06-10 14:19 ` [PATCH v3 2/9] x86: objtool: use asm macro for better compiler decisions Nadav Amit
2018-06-10 14:19 ` [PATCH v3 3/9] x86: refcount: prevent gcc distortions Nadav Amit
2018-06-10 14:19 ` [PATCH v3 4/9] x86: alternatives: macrofy locks for better inlining Nadav Amit
2018-06-11 8:03 ` Peter Zijlstra [this message]
2018-06-10 14:19 ` [PATCH v3 5/9] x86: bug: prevent gcc distortions Nadav Amit
2018-06-10 14:19 ` [PATCH v3 6/9] x86: prevent inline distortion by paravirt ops Nadav Amit
2018-06-11 7:45 ` Peter Zijlstra
2018-06-12 3:49 ` Nadav Amit
2018-06-10 14:19 ` [PATCH v3 7/9] x86: extable: use macros instead of inline assembly Nadav Amit
2018-06-10 14:19 ` [PATCH v3 8/9] x86: cpufeature: " Nadav Amit
2018-06-10 14:19 ` [PATCH v3 9/9] x86: jump-labels: " Nadav Amit
2018-06-11 1:29 ` hpa
2018-06-11 3:47 ` Nadav Amit
2018-06-11 7:50 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611080314.GR12258@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome