From: Jan Kara <jack@suse.cz>
To: Shakeel Butt <shakeelb@google.com>
Cc: Jan Kara <jack@suse.com>, Greg Thelen <gthelen@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: reclaim least recently used dquots
Date: Mon, 11 Jun 2018 12:19:02 +0200 [thread overview]
Message-ID: <20180611101902.scimaa5dsvcoxfyy@quack2.suse.cz> (raw)
In-Reply-To: <20180608013759.46315-1-shakeelb@google.com>
On Thu 07-06-18 18:37:59, Shakeel Butt wrote:
> From: Greg Thelen <gthelen@google.com>
>
> The dquots in the free_dquots list are not reclaimed in LRU way.
> put_dquot_last() puts entries to the tail and dqcache_shrink_scan()
> frees from the tail. Free unreferenced dquots in LRU order because it
> seems more reasonable than freeing most recently used.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
Thanks. I've added the patch to my tree.
Honza
> ---
> fs/quota/dquot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index d88231e3b2be..241b00f835b9 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -716,7 +716,7 @@ dqcache_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
> unsigned long freed = 0;
>
> spin_lock(&dq_list_lock);
> - head = free_dquots.prev;
> + head = free_dquots.next;
> while (head != &free_dquots && sc->nr_to_scan) {
> dquot = list_entry(head, struct dquot, dq_free);
> remove_dquot_hash(dquot);
> @@ -725,7 +725,7 @@ dqcache_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
> do_destroy_dquot(dquot);
> sc->nr_to_scan--;
> freed++;
> - head = free_dquots.prev;
> + head = free_dquots.next;
> }
> spin_unlock(&dq_list_lock);
> return freed;
> --
> 2.18.0.rc1.242.g61856ae69a-goog
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2018-06-11 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 1:37 Shakeel Butt
2018-06-11 10:19 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611101902.scimaa5dsvcoxfyy@quack2.suse.cz \
--to=jack@suse.cz \
--cc=gthelen@google.com \
--cc=jack@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®