From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Lee Jones <lee.jones@linaro.org>, Rob Herring <robh@kernel.org>,
Johan Hovold <johan@kernel.org>
Subject: [PATCH v2 21/24] rave-sp: Support for variants on modalias drivers
Date: Mon, 11 Jun 2018 13:52:37 +0200 [thread overview]
Message-ID: <20180611115240.32606-22-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <20180611115240.32606-1-ricardo.ribalda@gmail.com>
Rave-sp behaves differently based on the device variant.
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Johan Hovold <johan@kernel.org>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/mfd/rave-sp.c | 30 +++++++++++++++++++++++-------
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
index c0ecfbc16dca..d33cb9d914e8 100644
--- a/drivers/mfd/rave-sp.c
+++ b/drivers/mfd/rave-sp.c
@@ -654,14 +654,30 @@ static const struct serdev_device_ops rave_sp_serdev_device_ops = {
.write_wakeup = serdev_device_write_wakeup,
};
+static struct serdev_device_id rave_sp_serdev_id[] = {
+ { "rave-sp", (kernel_ulong_t) &rave_sp_legacy},
+ { "rave-sp-niu", (kernel_ulong_t) &rave_sp_legacy},
+ { "rave-sp-mezz", (kernel_ulong_t) &rave_sp_legacy},
+ { "rave-sp-esb", (kernel_ulong_t) &rave_sp_legacy},
+ { "rave-sp-rdu1", (kernel_ulong_t) &rave_sp_rdu1},
+ { "rave-sp-rdu2", (kernel_ulong_t) &rave_sp_rdu2},
+ {}
+};
+MODULE_DEVICE_TABLE(serdev, rave_sp_serdev_id);
+
static int rave_sp_probe(struct serdev_device *serdev)
{
struct device *dev = &serdev->dev;
+ const struct serdev_device_id *id;
struct rave_sp *sp;
u32 baud;
int ret;
- if (of_property_read_u32(dev->of_node, "current-speed", &baud)) {
+ if (!dev->of_node) {
+ /* Baudrate at zii,rave-sp.txt */
+ baud = 1000000;
+ } else if (of_property_read_u32(dev->of_node,
+ "current-speed", &baud)) {
dev_err(dev,
"'current-speed' is not specified in device node\n");
return -EINVAL;
@@ -675,6 +691,12 @@ static int rave_sp_probe(struct serdev_device *serdev)
dev_set_drvdata(dev, sp);
sp->variant = of_device_get_match_data(dev);
+ if (!sp->variant) {
+ id = serdev_match_id(rave_sp_serdev_id, serdev);
+ if (id)
+ sp->variant = (const struct rave_sp_variant *)
+ id->driver_data;
+ }
if (!sp->variant)
return -ENODEV;
@@ -694,12 +716,6 @@ static int rave_sp_probe(struct serdev_device *serdev)
MODULE_DEVICE_TABLE(of, rave_sp_dt_ids);
-static struct serdev_device_id rave_sp_serdev_id[] = {
- { "rave-sp", },
- {}
-};
-MODULE_DEVICE_TABLE(serdev, rave_sp_serdev_id);
-
static struct serdev_device_driver rave_sp_drv = {
.probe = rave_sp_probe,
.driver = {
--
2.17.1
next prev parent reply other threads:[~2018-06-11 11:54 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 11:52 [PATCH v2 00/19] Dynamically load/remove serdev devices via sysfs* Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 01/24] serdev: Add id_table to serdev_device_driver Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 02/24] Bluetooth: hci_bcm: Add serdev_id_table Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 03/24] Bluetooth: hci_ll: " Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 04/24] Bluetooth: hci_nokia: " Ricardo Ribalda Delgado
2018-06-11 12:56 ` Marcel Holtmann
2018-06-11 13:04 ` Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 05/24] serdev: Introduce modalias field Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 06/24] serdev: Support bus matching with " Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 07/24] serdev: Allows dynamic creation of devices via sysfs Ricardo Ribalda Delgado
2018-06-11 12:39 ` Andy Shevchenko
2018-06-11 13:03 ` Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 08/24] serdev: Provide modalias attribute for modalias devices Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 09/24] serdev: Provide modalias uevent " Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 10/24] file2alias: Support for serdev devices Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 11/24] Bluetooth: hci_bcm: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-06-11 12:59 ` Marcel Holtmann
2018-06-11 13:31 ` Andy Shevchenko
2018-06-11 11:52 ` [PATCH v2 12/24] Bluetooth: hci_ll: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 13/24] Bluetooth: hci_nokia: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 14/24] mfd: rave-sp: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-06-11 13:14 ` Marcel Holtmann
2018-06-11 15:18 ` Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 15/24] net: qualcomm: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-06-11 13:01 ` Marcel Holtmann
2018-06-11 15:09 ` Ricardo Ribalda Delgado
2018-06-11 15:28 ` Marcel Holtmann
2018-06-11 15:33 ` Ricardo Ribalda Delgado
2018-06-11 15:52 ` Marcel Holtmann
2018-06-11 16:21 ` Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 16/24] serdev: ttyport: Move serport structure to its own header Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 17/24] serdev: Mark controllers compatible with ttyport Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 18/24] serdev: ttydev: Serdev driver that creates an standard TTY port Ricardo Ribalda Delgado
2018-06-13 1:20 ` Rob Herring
2018-06-13 6:35 ` Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 19/24] serdev: Instantiate a ttydev serdev if acpi and of fails Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 20/24] serdev: Make match_id accessible by drivers Ricardo Ribalda Delgado
2018-06-11 12:47 ` Andy Shevchenko
2018-06-11 13:10 ` Ricardo Ribalda Delgado
2018-06-11 11:52 ` Ricardo Ribalda Delgado [this message]
2018-06-11 12:54 ` [PATCH v2 21/24] rave-sp: Support for variants on modalias drivers Andy Shevchenko
2018-06-11 13:38 ` Marcel Holtmann
2018-06-11 15:21 ` Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 22/24] serdev: Replace IDA functions with IDR Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 23/24] serdev: get/put controller Ricardo Ribalda Delgado
2018-06-11 11:52 ` [PATCH v2 24/24] serdev: serdev_controller_add_probed_device Ricardo Ribalda Delgado
2018-06-14 10:48 ` [PATCH v2 00/19] Dynamically load/remove serdev devices via sysfs* Johan Hovold
2018-06-14 11:06 ` Ricardo Ribalda Delgado
2018-06-14 13:33 ` Johan Hovold
2018-06-14 14:06 ` Ricardo Ribalda Delgado
2018-06-14 14:55 ` Johan Hovold
2018-06-14 15:20 ` Ricardo Ribalda Delgado
2018-06-14 15:47 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611115240.32606-22-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®