From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org by pdx-caf-mail.web.codeaurora.org (Dovecot) with LMTP id PjITFR6JHlsySAAAmS7hNA ; Mon, 11 Jun 2018 14:38:12 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id ABF6D607E4; Mon, 11 Jun 2018 14:38:12 +0000 (UTC) Authentication-Results: smtp.codeaurora.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="flH+Y8Qx" X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by smtp.codeaurora.org (Postfix) with ESMTP id 42B58607A4; Mon, 11 Jun 2018 14:38:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 42B58607A4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbeFKOiK (ORCPT + 19 others); Mon, 11 Jun 2018 10:38:10 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56182 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893AbeFKOiI (ORCPT ); Mon, 11 Jun 2018 10:38:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uyVXhK36QtyNO3ODfhGBHrTY0DBp3d5lSAqgILFwYUw=; b=flH+Y8QxmH6Q/oP5MzEe3B7Mi siWn84RwRxaTo+Il6HlbYBYWRhtEyFo/Pd8WEE5OGAu1XigKVJonIUKXQ8K1IKzHmlpBgXGOj+BKB a45xwq0b4bLE6zRJMjKV+wPNed6Ts/1m6s01JveyY0FYitNTaSrqcW0F0s1wIghsUE+7pDhJfEfsT r9PtAphGiTncUwTp2JL1sd8s5BjRfoEMlSD+PzDmao0/i2zUOhRFEa+SwabnU5Pq687tqctkNy0Ab aei+VFdFdLfwKJU03b8t/gnTObtUYOhuc5dPL+n2iTdm0QoH8D4hG5Sj/3rRseCQZ3D9roqmUhiXe 54HzCxkCQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSNxL-0005fN-Kn; Mon, 11 Jun 2018 14:38:03 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AF70F201EA7A5; Mon, 11 Jun 2018 16:38:01 +0200 (CEST) Date: Mon, 11 Jun 2018 16:38:01 +0200 From: Peter Zijlstra To: Jeremy Cline Cc: Thomas Gleixner , "Rafael J. Wysocki" , rui.zhang@intel.com, len.brown@intel.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@leemhuis.info, Diego Viola Subject: Re: Regression: x86/tsc: Fix mark_tsc_unstable() Message-ID: <20180611143801.GH12235@hirez.programming.kicks-ass.net> References: <01000163ef24c875-daa2c00e-611e-4383-99a6-c8c72ef04a14-000000@email.amazonses.com> <20180611141742.GP12198@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180611141742.GP12198@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 11, 2018 at 04:17:42PM +0200, Peter Zijlstra wrote: > On Mon, Jun 11, 2018 at 01:59:15PM +0000, Jeremy Cline wrote: > > A user has bisected the problem to the v4.16 commit 1ab4ca7c59d4 > > ("x86/tsc: Fix mark_tsc_unstable()"). According to the reporter, > > explicitly setting "tsc=" on the kernel command line causes the boot to > > always succeed. All the users have Thinkpad T500s or T400s (Core 2 Duos) > > Weird. So Core2 typically triggers mark_tsc_unstable() in either > intel_idle or processor_idle. ISTR testing that when I did the patches. > > When I make that mark_tsc_unstable() in the idle drivers unconditional > and boot my ivb with that, it doesn't want to fail. I've booted the > machine 5 consequctive times without issue. > > Let me try and checkout -stable, maybe something's up with that. Nope -stable seems to be working as well on the IVB (with modification). I just dug up my T500 and that's actually still running the test kernel. Let me try and build the -stable kernel for that.