From: Dan Carpenter <dan.carpenter@oracle.com>
To: Zhouyang Jia <jiazhouyang09@gmail.com>
Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8712: add error handling for register_netdev
Date: Tue, 12 Jun 2018 14:34:22 +0300 [thread overview]
Message-ID: <20180612113422.tkta6ynquy6lfy7s@mwanda> (raw)
In-Reply-To: <1528773525-37564-1-git-send-email-jiazhouyang09@gmail.com>
On Tue, Jun 12, 2018 at 11:18:43AM +0800, Zhouyang Jia wrote:
> When register_netdev fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling register_netdev.
>
It doesn't add any error handling. It just adds an error message.
The error handling does look sort of messed up, but this isn't a useful
patch.
regards,
dan carpenter
prev parent reply other threads:[~2018-06-12 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 3:18 Zhouyang Jia
2018-06-12 11:34 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612113422.tkta6ynquy6lfy7s@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiazhouyang09@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®