From: Dan Carpenter <dan.carpenter@oracle.com>
To: Javier Martinez <javiermlinux@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] Staging: comedi: ssv_dnp: Remove unnecessary comment
Date: Thu, 14 Jun 2018 22:41:39 +0300 [thread overview]
Message-ID: <20180614194139.ou3cha5pgtvbbm2u@mwanda> (raw)
In-Reply-To: <20180614171911.GA1945@javier-Z97X>
On Thu, Jun 14, 2018 at 01:19:12PM -0400, Javier Martinez wrote:
> Removal of a comment that was not needed at all.
> We can clearly see that they are include/header files.
>
> Signed-off-by: Javier Martinez <javiermlinux@gmail.com>
> ---
> drivers/staging/comedi/drivers/ssv_dnp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c b/drivers/staging/comedi/drivers/ssv_dnp.c
> index 0628060e42ca..50de018ab9bb 100644
> --- a/drivers/staging/comedi/drivers/ssv_dnp.c
> +++ b/drivers/staging/comedi/drivers/ssv_dnp.c
> @@ -16,7 +16,6 @@
> * Status: unknown
> */
>
> -/* include files ----------------------------------------------------------- */
>
You need to remove a blank line or I think checkpatch.pl will complain
if you re-run it over the whole file. (You aren't allowed to have
multiple blank lines in a row).
regards,
dan carpenter
prev parent reply other threads:[~2018-06-14 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 17:19 Javier Martinez
2018-06-14 19:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614194139.ou3cha5pgtvbbm2u@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=javiermlinux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®