From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
y2038@lists.linaro.org, devel@driverdev.osuosl.org,
Micky Ching <micky_ching@realsil.com.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtsx: remove rtsx_trace() and related code
Date: Mon, 18 Jun 2018 17:57:55 +0300 [thread overview]
Message-ID: <20180618145754.kxos3ecd3q3eeigr@mwanda> (raw)
In-Reply-To: <20180618143802.4124691-1-arnd@arndb.de>
> @@ -117,7 +112,6 @@ static int ms_transfer_data(struct rtsx_chip *chip, u8 trans_mode,
> enum dma_data_direction dir;
>
> if (!buf || !buf_len) {
> - rtsx_trace(chip);
> return STATUS_FAIL;
> }
>
You're introducing a bunch of checkpatch.pl warnings. Normally we would
ask you to not do that... I don't care too much because someone will
eventually fix it, but still...
regards,
dan carpenter
prev parent reply other threads:[~2018-06-18 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 14:38 Arnd Bergmann
2018-06-18 14:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618145754.kxos3ecd3q3eeigr@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®