From: Mark Rutland <mark.rutland@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
boqun.feng@gmail.com, mingo@kernel.org, albert@sifive.com,
arnd@arndb.de, benh@kernel.crashing.org, geert@linux-m68k.org,
ink@jurassic.park.msu.ru, linux@armlinux.org.uk,
mattst88@gmail.com, mpe@ellerman.id.au, palmer@sifive.com,
paulus@samba.org, rth@twiddle.net, vgupta@synopsys.com
Subject: Re: [PATCHv3 00/18] atomics: API cleanups
Date: Mon, 18 Jun 2018 20:21:27 +0100 [thread overview]
Message-ID: <20180618192126.l7qyuthsc6eqkigb@salmiak> (raw)
In-Reply-To: <20180618163805.GE11612@arm.com>
On Mon, Jun 18, 2018 at 05:38:06PM +0100, Will Deacon wrote:
> On Mon, Jun 18, 2018 at 11:19:01AM +0100, Mark Rutland wrote:
> > This series contains a few cleanups of the atomic API, fixing
> > inconsistencies between atomic_* and atomic64_*, and minimizing
> > repetition in arch code. This is nicer for arch code, and the improved
> > regularity will help when generating the atomic headers in future.
>
> Apart from the Alpha patch:
>
> Reviewed-by: Will Deacon <will.deacon@arm.com>
Cheers! I assume that also holds with patch 7 fixes up to use s64.
> I also tried to compare disassembly before/after, but the changes to
> add_unless made that quite fiddly for anything using it as a backend.
>
> Do you plan to move arm64 over to atomic-instrumented.h at some point?
That's the plan -- there's still a way to go with the generated atomic headers
for that to work.
Thanks,
Mark.
next prev parent reply other threads:[~2018-06-18 19:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 10:19 Mark Rutland
2018-06-18 10:19 ` [PATCHv3 01/18] atomics/treewide: s/__atomic_add_unless/atomic_fetch_add_unless/ Mark Rutland
2018-06-18 10:19 ` [PATCHv3 02/18] atomics/treewide: remove redundant atomic_inc_not_zero() definitions Mark Rutland
2018-06-18 10:19 ` [PATCHv3 03/18] atomics/treewide: remove atomic_inc_not_zero_hint() Mark Rutland
2018-06-18 10:19 ` [PATCHv3 04/18] atomics: make conditional ops return bool Mark Rutland
2018-06-18 10:19 ` [PATCHv3 05/18] atomics/treewide: make atomic64_inc_not_zero() optional Mark Rutland
2018-06-18 10:19 ` [PATCHv3 06/18] atomics/treewide: make atomic_fetch_add_unless() optional Mark Rutland
2018-06-18 10:19 ` [PATCHv3 07/18] atomics: prepare for atomic64_fetch_add_unless() Mark Rutland
2018-06-18 16:10 ` Mark Rutland
2018-06-18 10:19 ` [PATCHv3 08/18] atomics/generic: define atomic64_fetch_add_unless() Mark Rutland
2018-06-18 10:19 ` [PATCHv3 09/18] atomics/alpha: " Mark Rutland
2018-06-18 15:54 ` Will Deacon
2018-06-18 16:08 ` Mark Rutland
2018-06-21 11:00 ` Ingo Molnar
2018-06-18 10:19 ` [PATCHv3 10/18] atomics/arc: " Mark Rutland
2018-06-18 10:19 ` [PATCHv3 11/18] atomics/arm: " Mark Rutland
2018-06-18 10:19 ` [PATCHv3 12/18] atomics/powerpc: " Mark Rutland
2018-06-18 10:19 ` [PATCHv3 13/18] atomics/riscv: " Mark Rutland
2018-06-18 10:19 ` [PATCHv3 14/18] atomics/treewide: make atomic64_fetch_add_unless() optional Mark Rutland
2018-06-18 10:19 ` [PATCHv3 15/18] atomics/treewide: make test ops optional Mark Rutland
2018-06-18 10:19 ` [PATCHv3 16/18] atomics/treewide: make unconditional inc/dec " Mark Rutland
2018-06-18 10:19 ` [PATCHv3 17/18] atomics/treewide: make conditional " Mark Rutland
2018-06-18 10:19 ` [PATCHv3 18/18] atomics/treewide: clean up andnot ifdeffery Mark Rutland
2018-06-18 16:38 ` [PATCHv3 00/18] atomics: API cleanups Will Deacon
2018-06-18 19:21 ` Mark Rutland [this message]
2018-06-19 10:18 ` Mark Rutland
2018-06-19 10:20 ` Will Deacon
2018-06-19 10:38 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618192126.l7qyuthsc6eqkigb@salmiak \
--to=mark.rutland@arm.com \
--cc=albert@sifive.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=geert@linux-m68k.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mattst88@gmail.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=palmer@sifive.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rth@twiddle.net \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®