From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB084C433EF for ; Tue, 19 Jun 2018 06:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64A672083A for ; Tue, 19 Jun 2018 06:28:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64A672083A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937295AbeFSG2T (ORCPT ); Tue, 19 Jun 2018 02:28:19 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:56342 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755560AbeFSG2S (ORCPT ); Tue, 19 Jun 2018 02:28:18 -0400 Received: from hsi-kbw-5-158-153-52.hsi19.kabel-badenwuerttemberg.de ([5.158.153.52] helo=kurt.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1fVA7h-0000c1-CH; Tue, 19 Jun 2018 08:28:13 +0200 From: Kurt Kanzenbach To: adrian.hunter@intel.com Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, kurt@linutronix.de Subject: [PATCH 1/1] mmc: sdhci-pci: fix eMMC controller issue on Intel Baytrail SoCs Date: Tue, 19 Jun 2018 08:31:19 +0200 Message-Id: <20180619063119.3955-2-kurt@linutronix.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619063119.3955-1-kurt@linutronix.de> References: <20180619063119.3955-1-kurt@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sometimes the eMMC controller doesn't respond anymore on Intel Baytrail SoCs. The resulting error looks like: |mmc1: Reset 0x1 never completed. |sdhci: =========== REGISTER DUMP (mmc1)=========== |sdhci: Sys addr: 0xffffffff | Version: 0x0000ffff |sdhci: Blk size: 0x0000ffff | Blk cnt: 0x0000ffff |sdhci: Argument: 0xffffffff | Trn mode: 0x0000ffff |sdhci: Present: 0xffffffff | Host ctl: 0x000000ff |sdhci: Power: 0x000000ff | Blk gap: 0x000000ff |sdhci: Wake-up: 0x000000ff | Clock: 0x0000ffff |sdhci: Timeout: 0x000000ff | Int stat: 0xffffffff |sdhci: Int enab: 0xffffffff | Sig enab: 0xffffffff |sdhci: AC12 err: 0x0000ffff | Slot int: 0x0000ffff |sdhci: Caps: 0xffffffff | Caps_1: 0xffffffff |sdhci: Cmd: 0x0000ffff | Max curr: 0xffffffff |sdhci: Host ctl2: 0x0000ffff |sdhci: ADMA Err: 0xffffffff | ADMA Ptr: 0xffffffff The behavior was observed on an Intel Atom E3825 performing lots of reboots. The issue seems to occur if runtime power management is used. Found by utilizing ftrace. The erratum VLI10 for the Intel E3825 states, that the eMMC controller incorrectly announces that it supports suspend/resume. However, that shouldn't be used, as the controller may incorrectly transfer data between memory and the SD device. Therefore, disallowing runtime pm resolves the issue. Tested on the E3825. Signed-off-by: Kurt Kanzenbach --- drivers/mmc/host/sdhci-pci-core.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c index 77dd3521daae..df89381944cd 100644 --- a/drivers/mmc/host/sdhci-pci-core.c +++ b/drivers/mmc/host/sdhci-pci-core.c @@ -870,6 +870,21 @@ static const struct sdhci_pci_fixes sdhci_intel_byt_emmc = { .priv_size = sizeof(struct intel_host), }; +/* + * See Erratum VLI10 from Errata List for Intel Atom E3825, Link: + * https://www.intel.ca/content/dam/www/public/us/en/documents/specification-updates/atom-e3800-family-spec-update.pdf + */ +static const struct sdhci_pci_fixes sdhci_intel_byt_emmc_no_runtime_pm = { + .allow_runtime_pm = false, + .probe_slot = byt_emmc_probe_slot, + .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC, + .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN | + SDHCI_QUIRK2_CAPS_BIT63_FOR_HS400 | + SDHCI_QUIRK2_STOP_WITH_TC, + .ops = &sdhci_intel_byt_ops, + .priv_size = sizeof(struct intel_host), +}; + static const struct sdhci_pci_fixes sdhci_intel_glk_emmc = { .allow_runtime_pm = true, .probe_slot = glk_emmc_probe_slot, @@ -1470,7 +1485,7 @@ static const struct pci_device_id pci_ids[] = { SDHCI_PCI_SUBDEVICE(INTEL, BYT_SDIO, NI, 7884, ni_byt_sdio), SDHCI_PCI_DEVICE(INTEL, BYT_SDIO, intel_byt_sdio), SDHCI_PCI_DEVICE(INTEL, BYT_SD, intel_byt_sd), - SDHCI_PCI_DEVICE(INTEL, BYT_EMMC2, intel_byt_emmc), + SDHCI_PCI_DEVICE(INTEL, BYT_EMMC2, intel_byt_emmc_no_runtime_pm), SDHCI_PCI_DEVICE(INTEL, BSW_EMMC, intel_byt_emmc), SDHCI_PCI_DEVICE(INTEL, BSW_SDIO, intel_byt_sdio), SDHCI_PCI_DEVICE(INTEL, BSW_SD, intel_byt_sd), -- 2.11.0