From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] __poll_t regressions this cycle
Date: Wed, 20 Jun 2018 04:33:21 +0100 [thread overview]
Message-ID: <20180620033321.GR30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFzt37S-iKfHAuCL=5XhCvEtRARfs_exyn2o-0LzCWFvXQ@mail.gmail.com>
On Wed, Jun 20, 2018 at 10:57:41AM +0900, Linus Torvalds wrote:
> On Mon, Jun 18, 2018 at 10:47 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Do you prefer it in one commit, or split into per-driver pieces?
>
> If it's all the exact same issue with the same commit message, then
> just one commit.
Some EPOLL... misspelled as POLL..., some ->poll() instances declared
as returning unsigned int instead of __poll_t and some __poll_t local
variables declared unsigned int. The only case beyond misannotations
is POLLWRNORM instead of EPOLLWRNORM - basically, on sparc, mips et.al.
EPOLLWRNORM (via epoll(7)) doesn't trigger for mei and xsk. Which
used to be the case for all drivers (only EPOLLOUT used to trigger on
these architectures) before the fixes this February...
prev parent reply other threads:[~2018-06-20 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 13:47 Al Viro
2018-06-20 1:57 ` Linus Torvalds
2018-06-20 3:33 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620033321.GR30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®