From: Joel Fernandes <joel@joelfernandes.org>
To: Alistair Strachan <astrachan@google.com>
Cc: linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
devel@driverdev.osuosl.org, kernel-team@android.com
Subject: Re: [PATCH 1/2] staging: android: ashmem: Remove use of unlikely()
Date: Tue, 19 Jun 2018 21:32:27 -0700 [thread overview]
Message-ID: <20180620043227.GB10888@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <20180620005735.219840-1-astrachan@google.com>
On Tue, Jun 19, 2018 at 05:57:34PM -0700, Alistair Strachan wrote:
> There is no speed difference, and it makes the code harder to read.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Arve Hjønnevåg <arve@android.com>
> Cc: Todd Kjos <tkjos@android.com>
> Cc: Martijn Coenen <maco@android.com>
> Cc: devel@driverdev.osuosl.org
> Cc: linux-kernel@vger.kernel.org
> Cc: kernel-team@android.com
> Cc: Joel Fernandes <joel@joelfernandes.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Alistair Strachan <astrachan@google.com>
Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>
thanks,
- Joel
prev parent reply other threads:[~2018-06-20 4:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 0:57 Alistair Strachan
2018-06-20 0:57 ` [PATCH 2/2 v2] staging: android: ashmem: Fix mmap size validation Alistair Strachan
2018-06-20 4:32 ` Joel Fernandes
2018-06-20 21:21 ` Daniel Colascione
2018-06-20 23:29 ` Joel Fernandes
2018-06-22 8:48 ` Martijn Coenen
2018-06-20 4:32 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620043227.GB10888@joelaf.mtv.corp.google.com \
--to=joel@joelfernandes.org \
--cc=arve@android.com \
--cc=astrachan@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®