From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: cocci@systeme.lip6.fr, Julia Lawall <Julia.Lawall@lip6.fr>,
gregkh@linuxfoundation.org, quytelda@tamalin.org,
Larry.Finger@lwfinger.net, harshasharmaiitr@gmail.com,
arushisinghal19971997@gmail.com, amitoj1606@gmail.com,
jeremy.lefaure@lse.epita.fr, teo.dacquet@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Fix two possible sleep-in-atomic-context bugs in translate_scan()
Date: Wed, 20 Jun 2018 13:22:49 +0300 [thread overview]
Message-ID: <20180620102249.djwmdv34zp5vyj2h@mwanda> (raw)
In-Reply-To: <dd6eaaad-413e-bd5d-d0f4-0a6d05438395@gmail.com>
On Wed, Jun 20, 2018 at 06:05:06PM +0800, Jia-Ju Bai wrote:
> > Thanks! It occurs to me that another way to detect this bug is that
> > one of the allocations in this function already uses GFP_ATOMIC. It
> > doesn't normally make sense to mix GFP_ATOMIC and GFP_KERNEL when there
> > isn't any locking in the function.
>
> Yes, this pattern is interesting for bug finding :)
> But to fix the bugs of this pattern, we need to decide whether GFP_ATOMIC or
> GFP_KERNEL should be used here.
>
Sure. But either way it's a bug. Plus this would be the first static
checker warning which warns about using GFP_ATOMIC when it's supposed to
be GFP_KERNEL. #milestone
regards,
dan carpenter
prev parent reply other threads:[~2018-06-20 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 9:50 Jia-Ju Bai
2018-06-20 9:56 ` Dan Carpenter
2018-06-20 10:05 ` Jia-Ju Bai
2018-06-20 10:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620102249.djwmdv34zp5vyj2h@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Julia.Lawall@lip6.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=amitoj1606@gmail.com \
--cc=arushisinghal19971997@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=cocci@systeme.lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=jeremy.lefaure@lse.epita.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
--cc=teo.dacquet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®