From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: acme@kernel.org, jolsa@redhat.com
Cc: alexander.shishkin@linux.intel.com, namhyung@kernel.org,
dsahern@gmail.com, davidcc@google.com, ak@linux.intel.com,
yao.jin@linux.intel.com, linux-kernel@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: [PATCH 3/3] perf script: Fix crash because of missing feat_op[] entry
Date: Wed, 20 Jun 2018 19:00:30 +0530 [thread overview]
Message-ID: <20180620133030.2188-4-ravi.bangoria@linux.ibm.com> (raw)
In-Reply-To: <20180620133030.2188-1-ravi.bangoria@linux.ibm.com>
perf_event__process_feature() tries to access feat_ops[feat].process
which is not defined for feat = HEADER_LAST_FEATURE and thus perf is
crashing. Add dummy entry for HEADER_LAST_FEATURE in the feat_ops.
Before:
# ./perf record -o - ls | ./perf script
Segmentation fault (core dumped)
After:
# ./perf record -o - ls | ./perf script
ls 7031 4392.099856: 250000 cpu-clock:uhH: 7f5e0ce7cd60
ls 7031 4392.100355: 250000 cpu-clock:uhH: 7f5e0c706ef7
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Fixes: 57b5de463925 ("perf report: Support forced leader feature in pipe mode")
---
| 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 540cd2dcd3e7..de8e3e29d870 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -2555,14 +2555,18 @@ struct feature_ops {
}
/* feature_ops not implemented: */
+#define write_last_feature NULL
+
#define print_tracing_data NULL
#define print_build_id NULL
+#define print_last_feature NULL
#define process_branch_stack NULL
#define process_stat NULL
+#define process_last_feature NULL
-static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
+static const struct feature_ops feat_ops[HEADER_LAST_FEATURE + 1] = {
FEAT_OPN(TRACING_DATA, tracing_data, false),
FEAT_OPN(BUILD_ID, build_id, false),
FEAT_OPR(HOSTNAME, hostname, false),
@@ -2585,6 +2589,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
FEAT_OPN(CACHE, cache, true),
FEAT_OPR(SAMPLE_TIME, sample_time, false),
FEAT_OPR(MEM_TOPOLOGY, mem_topology, true),
+ FEAT_OPN(LAST_FEATURE, last_feature, false),
};
struct header_print_data {
--
2.14.4
next prev parent reply other threads:[~2018-06-20 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 13:30 [PATCH 0/3] perf script: Few trivial fixes Ravi Bangoria
2018-06-20 13:30 ` [PATCH 1/3] perf script: Add missing output fields in a hint Ravi Bangoria
2018-06-20 13:30 ` [PATCH 2/3] perf script: Fix crash because of missing evsel->priv Ravi Bangoria
2018-06-20 13:52 ` Arnaldo Carvalho de Melo
2018-06-20 14:00 ` Ravi Bangoria
2018-06-22 3:53 ` Ravi Bangoria
2018-06-20 13:30 ` Ravi Bangoria [this message]
2018-06-20 13:49 ` [PATCH 3/3] perf script: Fix crash because of missing feat_op[] entry Arnaldo Carvalho de Melo
2018-06-20 14:09 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620133030.2188-4-ravi.bangoria@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®