mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	y2038@lists.linaro.org, Al Viro <viro@zeniv.linux.org.uk>,
	Jan Kara <jack@suse.cz>,
	reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] [v2] reiserfs: remove obsolete print_time function
Date: Wed, 20 Jun 2018 16:38:05 +0200	[thread overview]
Message-ID: <20180620143805.2pfhuy4tm5lc66tr@quack2.suse.cz> (raw)
In-Reply-To: <20180620142522.27639-3-arnd@arndb.de>

On Wed 20-06-18 16:25:04, Arnd Bergmann wrote:
> Before linux-2.4.6, print_time() was used to pretty-print an inode
> time when running reiserfs in user space, after that it has become
> obsolete and is still a bit incorrect: It behaves differently on 32-bit
> and 64-bit machines, and uses a static buffer to hold a string, which
> could lead to undefined behavior if we ever called this from multiple
> places simultaneously.
> 
> Since we always want to treat the timestamps as 'unsigned' anyway,
> simply printing them as an integer is both simpler and safer while
> avoiding the deprecated time_t type.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: after a second look, I decided to remove it instead of fixing it.

Yes, that's a good idea. The patch looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2018-06-20 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 14:25 [PATCH 1/3] [v2] reiserfs: remove unused j_timestamp Arnd Bergmann
2018-06-20 14:25 ` [PATCH 2/3] [v2] reiserfs: use monotonic time for j_trans_start_time Arnd Bergmann
2018-06-20 14:25 ` [PATCH 3/3] [v2] reiserfs: remove obsolete print_time function Arnd Bergmann
2018-06-20 14:38   ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180620143805.2pfhuy4tm5lc66tr@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiserfs-devel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®