From: Kees Cook <keescook@chromium.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Alasdair Kergon <agk@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Eric Biggers <ebiggers@google.com>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Lars Persson <larper@axis.com>, Mike Snitzer <snitzer@redhat.com>,
Rabin Vincent <rabinv@axis.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, qat-linux@intel.com,
dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 06/11] crypto: cbc: Remove VLA usage
Date: Wed, 20 Jun 2018 12:04:03 -0700 [thread overview]
Message-ID: <20180620190408.45104-7-keescook@chromium.org> (raw)
In-Reply-To: <20180620190408.45104-1-keescook@chromium.org>
In the quest to remove all stack VLA usage from the kernel[1], this
uses the upper bounds on blocksize.
[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
Signed-off-by: Kees Cook <keescook@chromium.org>
---
include/crypto/cbc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/crypto/cbc.h b/include/crypto/cbc.h
index f5b8bfc22e6d..260096bcf99b 100644
--- a/include/crypto/cbc.h
+++ b/include/crypto/cbc.h
@@ -113,7 +113,7 @@ static inline int crypto_cbc_decrypt_inplace(
unsigned int bsize = crypto_skcipher_blocksize(tfm);
unsigned int nbytes = walk->nbytes;
u8 *src = walk->src.virt.addr;
- u8 last_iv[bsize];
+ u8 last_iv[CRYPTO_ALG_MAX_BLOCKSIZE];
/* Start of the last block. */
src += nbytes - (nbytes & (bsize - 1)) - bsize;
--
2.17.1
next prev parent reply other threads:[~2018-06-20 19:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 19:03 [PATCH 00/11] crypto: " Kees Cook
2018-06-20 19:03 ` [PATCH 01/11] crypto: shash: " Kees Cook
2018-06-20 19:30 ` Christophe Leroy
2018-06-20 20:36 ` Kees Cook
2018-06-20 20:39 ` Christophe LEROY
2018-06-20 20:42 ` Kees Cook
2018-06-20 19:03 ` [PATCH 02/11] dm integrity: " Kees Cook
2018-06-20 19:04 ` [PATCH 03/11] crypto: ahash: " Kees Cook
2018-06-20 20:13 ` Christophe Leroy
2018-06-20 19:04 ` [PATCH 04/11] dm verity fec: " Kees Cook
2018-06-20 23:33 ` [dm-devel] " Eric Biggers
2018-06-20 23:44 ` Kees Cook
2018-06-21 2:30 ` Herbert Xu
2018-06-21 20:19 ` Kees Cook
2018-06-20 19:04 ` [PATCH 05/11] crypto alg: Introduce max blocksize and alignmask Kees Cook
2018-06-20 23:40 ` [dm-devel] " Eric Biggers
2018-06-21 0:04 ` Kees Cook
2018-06-21 0:32 ` Eric Biggers
2018-06-20 19:04 ` Kees Cook [this message]
2018-06-20 20:16 ` [PATCH 06/11] crypto: cbc: Remove VLA usage Christophe Leroy
2018-06-20 23:42 ` [dm-devel] " Eric Biggers
2018-06-20 19:04 ` [PATCH 07/11] crypto: xcbc: " Kees Cook
2018-06-20 23:46 ` [dm-devel] " Eric Biggers
2018-06-21 0:10 ` Kees Cook
2018-06-21 0:47 ` Eric Biggers
2018-06-20 19:04 ` [PATCH 08/11] crypto: qat: " Kees Cook
2018-06-20 19:04 ` [PATCH 09/11] crypto: shash: Remove VLA usage in unaligned hashing Kees Cook
2018-06-20 23:57 ` Eric Biggers
2018-06-21 0:15 ` Kees Cook
2018-06-20 19:04 ` [PATCH 10/11] crypto: ahash: Remove VLA usage for AHASH_REQUEST_ON_STACK Kees Cook
2018-06-20 19:04 ` [PATCH 11/11] crypto: skcipher: Remove VLA usage for SKCIPHER_REQUEST_ON_STACK Kees Cook
2018-06-20 19:44 ` Arnd Bergmann
2018-06-20 20:38 ` Kees Cook
2018-06-20 20:22 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620190408.45104-7-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=giovanni.cabiddu@intel.com \
--cc=gustavo@embeddedor.com \
--cc=herbert@gondor.apana.org.au \
--cc=larper@axis.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=rabinv@axis.com \
--cc=snitzer@redhat.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®