From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F1EC43143 for ; Fri, 22 Jun 2018 00:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 042DE22B63 for ; Fri, 22 Jun 2018 00:32:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 042DE22B63 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934033AbeFVAb7 (ORCPT ); Thu, 21 Jun 2018 20:31:59 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40470 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933466AbeFVAb5 (ORCPT ); Thu, 21 Jun 2018 20:31:57 -0400 Received: from localhost (unknown [119.205.93.152]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0BEE612128E20; Thu, 21 Jun 2018 17:31:54 -0700 (PDT) Date: Fri, 22 Jun 2018 09:31:50 +0900 (KST) Message-Id: <20180622.093150.372475753380132826.davem@davemloft.net> To: colin.king@canonical.com Cc: f.fainelli@gmail.com, ivan.khoronzhuk@linaro.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: davinci_cpdma: make function cpdma_desc_pool_create static From: David Miller In-Reply-To: <20180621171645.29734-1-colin.king@canonical.com> References: <20180621171645.29734-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Jun 2018 17:31:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 21 Jun 2018 18:16:45 +0100 > From: Colin Ian King > > The function cpdma_desc_pool_create is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'cpdma_desc_pool_create' was not declared. Should it > be static? > > Signed-off-by: Colin Ian King Applied, thanks Colin.