From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734E4C43144 for ; Fri, 22 Jun 2018 21:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 238F224899 for ; Fri, 22 Jun 2018 21:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Pk5HRuYE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 238F224899 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754311AbeFVVFj (ORCPT ); Fri, 22 Jun 2018 17:05:39 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59166 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbeFVVFh (ORCPT ); Fri, 22 Jun 2018 17:05:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BabDrm1yDjPbpIPXSIGxZIJV+PjXK4YDzvGPuzJBoO4=; b=Pk5HRuYEit4Sv6OqX2iqGufZa NCMqxjrSoYpF/tjfWAKIyGm+nK0hWucjrKVwy25k79r3x4rSl1CKullyGYk87x/EkodurQCDaHHae FSWvyVJrbk0fmK6xm+eky1jMwTPqW2RY+zHRrzaWx7u5XxDuEDttE3gAwT//yDD5AzTcthIZDWZkG DqRTXwraqD3HR4lnLL1p2mVPHLoatNtmV41KNoIIBvIr7IsXehanLq/dtSgjKpcVhPbzfl7JngH9n 76vS+xXx6arTLY24zap/EzL0oNcN+rCZRp1yMyNOhy+Jz3e/BU/XnpGJMi3+PXCMGMiw1AqTB57is nYU39mTow==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fWTFA-0000ID-6F; Fri, 22 Jun 2018 21:05:20 +0000 Date: Fri, 22 Jun 2018 14:05:19 -0700 From: Matthew Wilcox To: Guenter Roeck Cc: Josef Bacik , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: m68k boot failure in -next bisected to 'xarray: Replace exceptional entries' Message-ID: <20180622210519.GA18630@bombadil.infradead.org> References: <20180622184246.GA21226@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180622184246.GA21226@roeck-us.net> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 22, 2018 at 11:42:46AM -0700, Guenter Roeck wrote: > Hi, > > a few days ago, m68k boot tests in linux-next started to crash. > I bisected the problem to commit 'xarray: Replace exceptional entries'. > Bisect and crash logs are attached below. Thank you! I was afraid something like this might happen. > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at lib/idr.c:42 idr_alloc_u32+0x44/0xe8 Line 42 is: if (WARN_ON_ONCE(radix_tree_is_internal_node(ptr))) return -EINVAL; The pointer passed in to idr_alloc() is not 4-byte aligned; it's aligned to a 2 byte boundary. I'm having a little trouble seeing who it is that's passing in what pointer ... > Call Trace: [<000180d6>] __warn+0xc0/0xc2 > [<000020e8>] do_one_initcall+0x0/0x140 > [<0001816a>] warn_slowpath_null+0x26/0x2c > [<002b50e4>] idr_alloc_u32+0x44/0xe8 > [<002b50e4>] idr_alloc_u32+0x44/0xe8 > [<002b51e4>] idr_alloc+0x5c/0x76 > [<00247160>] genl_register_family+0x14c/0x54c It makes sense to here (other than idr_alloc being listed twice) > [<000020e8>] do_one_initcall+0x0/0x140 > [<003f0f02>] genl_init+0x0/0x34 Assuming this is right, that would imply that genl_ctrl is not 4-byte aligned. Is that true? I'm not familiar with the m68k alignment rules, but it has a lot of 4-byte sized quantities in the struct, so I would assume it's 4-byte aligned. > [<003f0ce6>] bpf_lwt_init+0x10/0x14 I don't think this is the caller. > [<003f0f0e>] genl_init+0xc/0x34 > [<00002142>] do_one_initcall+0x5a/0x140 > [<00029828>] parse_args+0x0/0x202 > [<000020e8>] do_one_initcall+0x0/0x140 > [<002bf6c4>] strcpy+0x0/0x1c > [<00040004>] timekeeping_resume+0x280/0x2cc > [<003df1e6>] kernel_init_freeable+0x176/0x190 > [<002bf6c4>] strcpy+0x0/0x1c > [<003df1fc>] kernel_init_freeable+0x18c/0x190 > [<003f0f02>] genl_init+0x0/0x34 > [<002c4b66>] kernel_init+0x0/0xd2 > [<002c4b6e>] kernel_init+0x8/0xd2 > [<002c4b66>] kernel_init+0x0/0xd2 > [<000028e0>] ret_from_kernel_thread+0xc/0x14 > ---[ end trace 62c263e59debfdfe ]--- > Kernel panic - not syncing: GENL: Cannot register controller: -22