From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63041C43144 for ; Sat, 23 Jun 2018 01:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 169D224A62 for ; Sat, 23 Jun 2018 01:24:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 169D224A62 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934599AbeFWBYo (ORCPT ); Fri, 22 Jun 2018 21:24:44 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33854 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933850AbeFWBYm (ORCPT ); Fri, 22 Jun 2018 21:24:42 -0400 Received: from localhost (unknown [211.196.191.92]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B9F091264BF4A; Fri, 22 Jun 2018 18:24:40 -0700 (PDT) Date: Sat, 23 Jun 2018 10:24:35 +0900 (KST) Message-Id: <20180623.102435.440104910657366197.davem@davemloft.net> To: jasowang@redhat.com Cc: mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH net] vhost_net: validate sock before trying to put its fd From: David Miller In-Reply-To: <1529557891-4828-1-git-send-email-jasowang@redhat.com> References: <1529557891-4828-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Jun 2018 18:24:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Thu, 21 Jun 2018 13:11:31 +0800 > Sock will be NULL if we pass -1 to vhost_net_set_backend(), but when > we meet errors during ubuf allocation, the code does not check for > NULL before calling sockfd_put(), this will lead NULL > dereferencing. Fixing by checking sock pointer before. > > Fixes: bab632d69ee4 ("vhost: vhost TX zero-copy support") > Reported-by: Dan Carpenter > Signed-off-by: Jason Wang Applied and queued up for -stable, thanks Jason.