From: Alex Elder <elder@linaro.org>
To: andy.gross@linaro.org
Cc: clew@codeaurora.org, aneela@codeaurora.org,
david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH resend 10/12] soc: qcom: smem: small change in global entry loop
Date: Mon, 25 Jun 2018 19:58:54 -0500 [thread overview]
Message-ID: <20180626005856.14174-11-elder@linaro.org> (raw)
In-Reply-To: <20180626005856.14174-1-elder@linaro.org>
Change the logic in the loop that finds that global host entry in
the partition table not require the host0 and host1 local variables.
The next patch will remove them.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/soc/qcom/smem.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index f5d7af1623a9..8597aa03232c 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -784,9 +784,10 @@ static int qcom_smem_set_global_partition(struct qcom_smem *smem)
if (!le32_to_cpu(entry->size))
continue;
- host0 = le16_to_cpu(entry->host0);
- host1 = le16_to_cpu(entry->host1);
- if (host0 == SMEM_GLOBAL_HOST && host0 == host1) {
+ if (le16_to_cpu(entry->host0) != SMEM_GLOBAL_HOST)
+ continue;
+
+ if (le16_to_cpu(entry->host1) == SMEM_GLOBAL_HOST) {
found = true;
break;
}
--
2.17.1
next prev parent reply other threads:[~2018-06-26 0:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 0:58 [PATCH resend 00/12] soc: qcom: smem: some refactoring Alex Elder
2018-06-26 0:58 ` [PATCH resend 01/12] soc: qcom: smem: rename variable in qcom_smem_get_global() Alex Elder
2018-06-26 0:58 ` [PATCH resend 02/12] soc: qcom: smem: initialize region struct only when successful Alex Elder
2018-06-26 0:58 ` [PATCH resend 03/12] soc: qcom: smem: always ignore partitions with 0 offset or size Alex Elder
2018-06-26 0:58 ` [PATCH resend 04/12] soc: qcom: smem: small refactor in qcom_smem_enumerate_partitions() Alex Elder
2018-06-26 0:58 ` [PATCH resend 05/12] soc: qcom: smem: verify both host ids in partition header Alex Elder
2018-06-26 0:58 ` [PATCH resend 06/12] soc: qcom: smem: require order of host ids to match Alex Elder
2018-06-26 0:58 ` [PATCH resend 07/12] soc: qcom: smem: introduce qcom_smem_partition_header() Alex Elder
2018-06-26 0:58 ` [PATCH resend 08/12] soc: qcom: smem: verify partition header size Alex Elder
2018-06-26 0:58 ` [PATCH resend 09/12] soc: qcom: smem: verify partition offset_free_uncached Alex Elder
2018-06-26 0:58 ` Alex Elder [this message]
2018-06-26 0:58 ` [PATCH resend 11/12] soc: qcom: smem: verify partition host ids match Alex Elder
2018-06-26 0:58 ` [PATCH resend 12/12] soc: qcom: smem: a few last cleanups Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626005856.14174-11-elder@linaro.org \
--to=elder@linaro.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®