From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDD1C43142 for ; Tue, 26 Jun 2018 08:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 756502671C for ; Tue, 26 Jun 2018 08:55:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 756502671C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933206AbeFZIzG (ORCPT ); Tue, 26 Jun 2018 04:55:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:43958 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752617AbeFZIyv (ORCPT ); Tue, 26 Jun 2018 04:54:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EB64BACD9; Tue, 26 Jun 2018 08:54:49 +0000 (UTC) Date: Tue, 26 Jun 2018 10:54:49 +0200 From: Michal Hocko To: Thomas Gleixner Cc: "Kani, Toshi" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "x86@kernel.org" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "mingo@redhat.com" , "linux-arm-kernel@lists.infradead.org" , "cpandya@codeaurora.org" Subject: Re: [PATCH v3 0/3] fix free pmd/pte page handlings on x86 Message-ID: <20180626085449.GU28965@dhcp22.suse.cz> References: <20180516233207.1580-1-toshi.kani@hpe.com> <1529938470.14039.134.camel@hpe.com> <20180625175225.GQ28965@dhcp22.suse.cz> <1529961187.14039.206.camel@hpe.com> <20180626063521.GT28965@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 26-06-18 10:45:11, Thomas Gleixner wrote: > On Tue, 26 Jun 2018, Michal Hocko wrote: > > On Mon 25-06-18 21:15:03, Kani Toshimitsu wrote: > > > Lastly, for the code maintenance, I believe this memory allocation keeps > > > the code much simpler than it would otherwise need to manage a special > > > page list. > > > > Yes, I can see a simplicity as a reasonable argument for a quick fix, > > which these pile is supposed to be AFAIU. So this might be good to go > > from that perspective, but I believe that this should be changed in > > future at least. > > So the conclusion is, that we ship this set of patches now to cure the > existing wreckage, right? Joerg was suggesting some alternative but I got lost in the discussion to be honest so I might mis{interpret,remember}. > Fine with that, but who will take care of reworking it proper? I'm > concerned that this will just go stale the moment the fixes hit the tree. Yeah, this is why I usually try to push back hard because "will be fixed later" is similar to say "documentation will come later" etc... A big fat TODO would be appropriate so it won't get forgotten at least. -- Michal Hocko SUSE Labs