From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA15CC43142 for ; Tue, 26 Jun 2018 14:47:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F6D826C94 for ; Tue, 26 Jun 2018 14:47:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F6D826C94 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965796AbeFZOrp (ORCPT ); Tue, 26 Jun 2018 10:47:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:57150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965359AbeFZOrn (ORCPT ); Tue, 26 Jun 2018 10:47:43 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3072626C93; Tue, 26 Jun 2018 14:47:42 +0000 (UTC) Date: Tue, 26 Jun 2018 10:47:40 -0400 From: Steven Rostedt To: Hans de Goede Cc: Bartlomiej Zolnierkiewicz , Petr Mladek , Sergey Senozhatsky , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable Message-ID: <20180626104740.0067bd5e@gandalf.local.home> In-Reply-To: <20180626135535.2990-3-hdegoede@redhat.com> References: <20180626135535.2990-1-hdegoede@redhat.com> <20180626135535.2990-3-hdegoede@redhat.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jun 2018 15:55:34 +0200 Hans de Goede wrote: > Replace comments about places where the console lock should be held with > calls to WARN_CONSOLE_UNLOCKED() to assert that it is actually held. Why replace the comments? I prefer them, even with the WARN. The reason is, when using functions, I don't tend to look inside the function I'm about to use, but instead, I expect the comment above the function to have basic information I need to use it. Especially what locks are expected to be held. Please keep the comments in place, but the WARNs are fine. They are not a replacement for the comments. Nack on removing comments. -- Steve