From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Allan Xavier <allan.x.xavier@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Fix GCC 8 cold function processing without -freorder-functions
Date: Tue, 26 Jun 2018 16:07:09 -0500 [thread overview]
Message-ID: <20180626210709.i2x5qrpu7bf5xi2p@treble> (raw)
In-Reply-To: <20180626194327.GP2494@hirez.programming.kicks-ass.net>
On Tue, Jun 26, 2018 at 09:43:27PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 26, 2018 at 01:44:05PM -0500, Josh Poimboeuf wrote:
> > On Tue, Jun 26, 2018 at 07:31:18PM +0100, Allan Xavier wrote:
>
> > > Is there a particular concern you're trying to address by having the logic there
> > > instead?
> >
> > Thanks for the patch and the excellent problem description. I think the
> > concern is that the overlap might cause other unforeseen issues (now or
> > in the future).
>
> Yeah, overlapping symbols are just really weird and unfortunate, I've no
> idea what the GCC people were thinking.
>
> Note how find_symbol_containing() already more or less assumed !overlap.
If there are no objections to my patch, I'll run it through 0-day
testing and post an official version tomorrow-ish if it doesn't break
anything.
--
Josh
next prev parent reply other threads:[~2018-06-26 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 16:20 Allan Xavier
2018-06-26 16:43 ` Peter Zijlstra
2018-06-26 18:31 ` Allan Xavier
2018-06-26 18:44 ` Josh Poimboeuf
2018-06-26 19:43 ` Peter Zijlstra
2018-06-26 21:07 ` Josh Poimboeuf [this message]
2018-06-27 9:35 ` Allan Xavier
2018-06-27 15:15 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626210709.i2x5qrpu7bf5xi2p@treble \
--to=jpoimboe@redhat.com \
--cc=allan.x.xavier@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®