From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56284C43144 for ; Wed, 27 Jun 2018 07:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0314B26679 for ; Wed, 27 Jun 2018 07:33:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0314B26679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbeF0Hdb (ORCPT ); Wed, 27 Jun 2018 03:33:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:39402 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbeF0Hda (ORCPT ); Wed, 27 Jun 2018 03:33:30 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4B00AAFFC; Wed, 27 Jun 2018 07:33:29 +0000 (UTC) Date: Wed, 27 Jun 2018 09:33:28 +0200 From: Johannes Thumshirn To: Keith Busch Cc: Keith Busch , Linux Kernel Mailinglist , Christoph Hellwig , Linux NVMe Mailinglist , Sagi Grimberg Subject: Re: [PATCH] nvme: trace: add disk name to tracepoints Message-ID: <20180627073328.aws2apvc357jobge@linux-x5ow.site> References: <20180626135141.14088-1-jthumshirn@suse.de> <20180626135141.14088-3-jthumshirn@suse.de> <20180626150106.GB6628@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180626150106.GB6628@localhost.localdomain> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 26, 2018 at 09:01:06AM -0600, Keith Busch wrote: > Not related to your patch, but I did notice that the req->q->id isn't > really useful here since that's not the hardware context identifier. > That's just some ida assigned software identifier. For the admin command > completion trace, it's actually a little confusing to see the qid in the > trace. It was actually requested by Martin so we can easily see which request got dispatched/completed on which request queue. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850