From: David Miller <davem@davemloft.net>
To: brandon.maier@rockwellcollins.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
michal.simek@xilinx.com, clayton.shotwell@rockwellcollins.com,
kristopher.cory@rockwellcollins.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/3] net: phy: xgmiitorgmii: Check phy_driver ready before accessing
Date: Thu, 28 Jun 2018 16:12:35 +0900 (KST) [thread overview]
Message-ID: <20180628.161235.277685925315349662.davem@davemloft.net> (raw)
In-Reply-To: <20180626175050.71165-1-brandon.maier@rockwellcollins.com>
From: Brandon Maier <brandon.maier@rockwellcollins.com>
Date: Tue, 26 Jun 2018 12:50:48 -0500
> Since a phy_device is added to the global mdio_bus list during
> phy_device_register(), but a phy_device's phy_driver doesn't get
> attached until phy_probe(). It's possible of_phy_find_device() in
> xgmiitorgmii will return a valid phy with a NULL phy_driver. Leading to
> a NULL pointer access during the memcpy().
>
> Fixes this Oops:
...
> Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Applied.
prev parent reply other threads:[~2018-06-28 7:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 17:50 Brandon Maier
2018-06-26 17:50 ` [PATCH net-next v2 2/3] net: phy: xgmiitorgmii: Use correct mdio bus Brandon Maier
2018-06-26 19:37 ` Andrew Lunn
2018-06-28 7:12 ` David Miller
2018-06-26 17:50 ` [PATCH net-next v2 3/3] net: phy: xgmiitorgmii: Check read_status results Brandon Maier
2018-06-26 19:38 ` Andrew Lunn
2018-06-28 7:12 ` David Miller
2018-06-26 19:36 ` [PATCH net-next v2 1/3] net: phy: xgmiitorgmii: Check phy_driver ready before accessing Andrew Lunn
2018-06-26 21:59 ` Florian Fainelli
2018-06-28 7:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628.161235.277685925315349662.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=brandon.maier@rockwellcollins.com \
--cc=clayton.shotwell@rockwellcollins.com \
--cc=f.fainelli@gmail.com \
--cc=kristopher.cory@rockwellcollins.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®