mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
	Daniel Mack <zonque@gmail.com>, Felipe Balbi <balbi@kernel.org>,
	Ruslan Bilovol <ruslan.bilovol@gmail.com>,
	Jassi Brar <jaswinder.singh@linaro.org>,
	Robert Baldyga <r.baldyga@samsung.com>,
	Peter Chen <peter.chen@nxp.com>, Christoph Hellwig <hch@lst.de>,
	Eugeniu Rosca <rosca.eugeniu@gmail.com>,
	Eugeniu Rosca <erosca@de.adit-jv.com>,
	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
	Joshua Frkuska <joshua_frkuska@mentor.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/7] Fix issues in UAC2 gadget driver
Date: Thu, 28 Jun 2018 13:39:30 +0200	[thread overview]
Message-ID: <20180628113930.GA8176@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <20180621152252.8313-1-erosca@de.adit-jv.com>

Hi Felipe,

Friendly reminder. May I have some feedback on the shared USB fixes?

Best regards,
Eugeniu.

On Thu, Jun 21, 2018 at 05:22:45PM +0200, Eugeniu Rosca wrote:
> Hello Felipe and linux-usb community,
> 
> This is a collection of UAC fixes, some of which have been written back
> in 2016 on top of v3.14. v4.13-rc1 commit eb9fecb9e69b ("usb: gadget:
> f_uac2: split out audio core") made forward-porting of these patches to
> recent kernels quite painful and time-consuming, so we decided to
> re-base them against v4.18-rc1, re-test and share them with community.
> 
> These changes have already undergone internal review, which includes:
> * static analysis:
>  - checkpatch --strict, cppcheck, smatch, sparse, coccicheck, make W=1
> * dynamic testing:
>  - Audio playback on host side and recording on gadget side, where the
>    latter is RCAR Gen3 Salvator-X arm64 target and the former is a
>    Ubuntu PC or an appropriate USB port on the same RCAR target.
>    The kernel was compiled with and w/o KA/UB sanitizers.
> 
> The "older" patches actually live in real Customer products.
> 
> Thank you in advance for any feedback/review comments.
> 
> Best regards,
> Eugeniu.
> 
> Contributors (auto-generated by git)
> 
> Andreas Pape (1):
>   usb: gadget: f_uac2: disable IN/OUT ep if unused
> 
> Eugeniu Rosca (2):
>   usb: gadget: f_uac2: fix error handling in afunc_bind (again)
>   usb: gadget: u_audio: fix pcm/card naming in g_audio_setup()
> 
> Joshua Frkuska (1):
>   usb: gadget: u_audio: update hw_ptr in iso_complete after data copied
> 
> Vladimir Zapolskiy (3):
>   usb: gadget: u_audio: remove caching of stream buffer parameters
>   usb: gadget: u_audio: remove cached period bytes value
>   usb: gadget: u_audio: protect stream runtime fields with stream
>     spinlock
> 
>  drivers/usb/gadget/function/f_uac2.c  | 216 ++++++++++++++++++++------
>  drivers/usb/gadget/function/u_audio.c |  88 ++++-------
>  2 files changed, 205 insertions(+), 99 deletions(-)
> 
> -- 
> 2.17.0
> 

       reply	other threads:[~2018-06-28 11:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180621152252.8313-1-erosca@de.adit-jv.com>
2018-06-28 11:39 ` Eugeniu Rosca [this message]
2018-06-29  6:41   ` Felipe Balbi
2018-06-29 11:28     ` Eugeniu Rosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628113930.GA8176@vmlxhi-102.adit-jv.com \
    --to=erosca@de.adit-jv.com \
    --cc=andrzej.p@samsung.com \
    --cc=balbi@kernel.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=jaswinder.singh@linaro.org \
    --cc=joshua_frkuska@mentor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=r.baldyga@samsung.com \
    --cc=rosca.eugeniu@gmail.com \
    --cc=ruslan.bilovol@gmail.com \
    --cc=vladimir_zapolskiy@mentor.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®