mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Andreas Klinger <ak@it-klinger.de>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Ben Whitten <ben.whitten@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Willy Tarreau <w@1wt.eu>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: ledtrig-morse: send out morse code
Date: Fri, 29 Jun 2018 04:24:39 -0400	[thread overview]
Message-ID: <20180629082439.GA15660@kroah.com> (raw)
In-Reply-To: <20180629080717.GA12112@amd>

On Fri, Jun 29, 2018 at 10:07:17AM +0200, Pavel Machek wrote:
> Hi!
> 
> > > There's no reason 2. should be in kernel ("mechanism, not policy").
> > >
> > > Given 1. is not really more complicated than the morse
> > > trigger... please just help with pattern trigger if you want this to
> > > happen.
> > 
> > Ah, you want to do the conversion to morse code in userspace?
> > Yes, that makes sense.
> 
> Yes, that's what I want.

We all want a pony :)

Seriously, this is a very simple module, works well, and makes some
system's life much easier as there is no external dependancy on a
text-to-morse-code library needed.

If you don't want this cluttering up your kernel, don't built it in.

I think it should be taken as-is (well, with the few changes already
recommended).

thanks,

greg k-h

  reply	other threads:[~2018-06-29  8:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 13:42 Andreas Klinger
2018-06-28 13:54 ` Greg KH
2018-06-28 15:36 ` Geert Uytterhoeven
2018-06-28 18:21 ` Willy Tarreau
2018-06-28 18:56 ` Pavel Machek
2018-06-28 20:29   ` Andreas Klinger
2018-06-28 20:45     ` Pavel Machek
2018-06-29  6:41       ` Andreas Klinger
2018-06-29  7:17         ` Pavel Machek
2018-06-29  7:21           ` Geert Uytterhoeven
2018-06-29  7:29             ` Pavel Machek
2018-06-29  7:48               ` Geert Uytterhoeven
2018-06-29  8:07                 ` Pavel Machek
2018-06-29  8:24                   ` Greg KH [this message]
2018-06-29  9:23                     ` Pavel Machek
2018-06-28 20:33   ` Andreas Klinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180629082439.GA15660@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ak@it-klinger.de \
    --cc=ben.whitten@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pombredanne@nexb.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome