From: Kim Phillips <kim.phillips@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Thomas Richter" <tmricht@linux.vnet.ibm.com>,
"Michael Petlan" <mpetlan@redhat.com>,
"Hendrik Brückner" <brueckner@linux.vnet.ibm.com>,
"Sandipan Das" <sandipan@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] perf test shell: make perf inet_pton test more portable
Date: Fri, 29 Jun 2018 11:11:30 -0500 [thread overview]
Message-ID: <20180629111130.fa4cc7d2bcd55e07a5298c1c@arm.com> (raw)
In-Reply-To: <20180629152155.GB3593@kernel.org>
On Fri, 29 Jun 2018 12:21:55 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Thu, Jun 21, 2018 at 03:32:50PM -0500, Kim Phillips escreveu:
> > On Thu, 21 Jun 2018 12:18:00 -0300
> > Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > > Would be good if we had some utility that given a two files, one with
> > > regexps, could tell if, line by line, those expressions matched, better,
> > > one that is present in all these OSes...
> >
> > I didn't find any, but given the two-file notion might be acceptable,
> > hopefully you might find the following more readable/acceptable?:
>
> Looks better, you build the expected lines in a separate file, then read
> both it and the output, then do the matching, cleaner. And I assume it
> works with dash, right?
Yes, of course :)
I'll re-send via a new v2 series as 1/2 wasn't git-am friendly, and
I've uncovered another minor bashism.
Kim
next prev parent reply other threads:[~2018-06-29 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 23:49 Kim Phillips
2018-06-20 6:59 ` Thomas-Mich Richter
2018-06-20 13:46 ` Arnaldo Carvalho de Melo
2018-06-21 0:45 ` Kim Phillips
2018-06-21 14:19 ` Arnaldo Carvalho de Melo
2018-06-21 15:18 ` Arnaldo Carvalho de Melo
2018-06-21 20:32 ` Kim Phillips
2018-06-29 15:21 ` Arnaldo Carvalho de Melo
2018-06-29 16:11 ` Kim Phillips [this message]
2018-06-28 20:36 ` Michael Petlan
2018-06-29 16:21 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629111130.fa4cc7d2bcd55e07a5298c1c@arm.com \
--to=kim.phillips@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan@linux.vnet.ibm.com \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome