From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com, haiyangz@linuxonhyperv.com
Cc: netdev@vger.kernel.org, kys@microsoft.com,
sthemmin@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] hv_netvsc: split sub-channel setup into async and sync
Date: Sat, 30 Jun 2018 21:29:30 +0900 (KST) [thread overview]
Message-ID: <20180630.212930.58049848439397621.davem@davemloft.net> (raw)
In-Reply-To: <20180629210716.6798-1-haiyangz@linuxonhyperv.com>
From: Haiyang Zhang <haiyangz@linuxonhyperv.com>
Date: Fri, 29 Jun 2018 14:07:16 -0700
> From: Stephen Hemminger <sthemmin@microsoft.com>
>
> When doing device hotplug the sub channel must be async to avoid
> deadlock issues because device is discovered in softirq context.
>
> When doing changes to MTU and number of channels, the setup
> must be synchronous to avoid races such as when MTU and device
> settings are done in a single ip command.
>
> Reported-by: Thomas Walker <Thomas.Walker@twosigma.com>
> Fixes: 8195b1396ec8 ("hv_netvsc: fix deadlock on hotplug")
> Fixes: 732e49850c5e ("netvsc: fix race on sub channel creation")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2018-06-30 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 21:07 Haiyang Zhang
2018-06-30 12:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180630.212930.58049848439397621.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@linuxonhyperv.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®