From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Jerome Brunet <jbrunet@baylibre.com>
Cc: kbuild-all@01.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: es7241: add es7241 codec support
Date: Sat, 30 Jun 2018 11:28:29 +0300 [thread overview]
Message-ID: <20180630082829.qwnhkk4f76n32omm@mwanda> (raw)
In-Reply-To: <20180629152444.21525-3-jbrunet@baylibre.com>
Hi Jerome,
I love your patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on v4.18-rc2 next-20180629]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jerome-Brunet/ASoC-add-es7241-support/20180630-021159
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
smatch warnings:
sound/soc/codecs/es7241.c:147 es7241_set_fmt() warn: missing break? reassigning 'priv->is_slave'
# https://github.com/0day-ci/linux/commit/d494a70ae50e5f95d2ab09bcaf3065b4359bde0e
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout d494a70ae50e5f95d2ab09bcaf3065b4359bde0e
vim +147 sound/soc/codecs/es7241.c
d494a70a Jerome Brunet 2018-06-29 123
d494a70a Jerome Brunet 2018-06-29 124 static int es7241_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
d494a70a Jerome Brunet 2018-06-29 125 {
d494a70a Jerome Brunet 2018-06-29 126 struct es7241_data *priv = snd_soc_dai_get_drvdata(dai);
d494a70a Jerome Brunet 2018-06-29 127
d494a70a Jerome Brunet 2018-06-29 128 if ((fmt & SND_SOC_DAIFMT_INV_MASK) != SND_SOC_DAIFMT_NB_NF) {
d494a70a Jerome Brunet 2018-06-29 129 dev_err(dai->dev, "Unsupported dai clock inversion\n");
d494a70a Jerome Brunet 2018-06-29 130 return -EINVAL;
d494a70a Jerome Brunet 2018-06-29 131 }
d494a70a Jerome Brunet 2018-06-29 132
d494a70a Jerome Brunet 2018-06-29 133 switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
d494a70a Jerome Brunet 2018-06-29 134 case SND_SOC_DAIFMT_I2S:
d494a70a Jerome Brunet 2018-06-29 135 case SND_SOC_DAIFMT_LEFT_J:
d494a70a Jerome Brunet 2018-06-29 136 break;
d494a70a Jerome Brunet 2018-06-29 137
d494a70a Jerome Brunet 2018-06-29 138 default:
d494a70a Jerome Brunet 2018-06-29 139 dev_err(dai->dev, "Unsupported dai format\n");
d494a70a Jerome Brunet 2018-06-29 140 return -EINVAL;
d494a70a Jerome Brunet 2018-06-29 141 }
d494a70a Jerome Brunet 2018-06-29 142
d494a70a Jerome Brunet 2018-06-29 143 switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
d494a70a Jerome Brunet 2018-06-29 144 case SND_SOC_DAIFMT_CBS_CFS:
d494a70a Jerome Brunet 2018-06-29 145 priv->is_slave = true;
d494a70a Jerome Brunet 2018-06-29 146 case SND_SOC_DAIFMT_CBM_CFM:
d494a70a Jerome Brunet 2018-06-29 @147 priv->is_slave = false;
d494a70a Jerome Brunet 2018-06-29 148 break;
d494a70a Jerome Brunet 2018-06-29 149
d494a70a Jerome Brunet 2018-06-29 150 default:
d494a70a Jerome Brunet 2018-06-29 151 dev_err(dai->dev, "Unsupported clock configuration\n");
d494a70a Jerome Brunet 2018-06-29 152 return -EINVAL;
d494a70a Jerome Brunet 2018-06-29 153 }
d494a70a Jerome Brunet 2018-06-29 154
d494a70a Jerome Brunet 2018-06-29 155 return 0;
d494a70a Jerome Brunet 2018-06-29 156 }
d494a70a Jerome Brunet 2018-06-29 157
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2018-06-30 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 15:24 [PATCH 0/2] ASoC: add es7241 support Jerome Brunet
2018-06-29 15:24 ` [PATCH 1/2] ASoC: es7241: add dt-bindings documentation for the es7241 adc Jerome Brunet
2018-06-29 15:24 ` [PATCH 2/2] ASoC: es7241: add es7241 codec support Jerome Brunet
2018-06-30 8:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180630082829.qwnhkk4f76n32omm@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®