From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: gengdongjiu <gengdongjiu@huawei.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
anna-maria@linutronix.de, john.stultz@linaro.org,
Hangaohuai <hangaohuai@huawei.com>,
"zhangjianwei (D)" <zhangjianwei8@huawei.com>,
yangchuanlong@huawei.com,
"Zhangbin (EulerOS)" <zhangbin46@huawei.com>,
liupeifeng3@huawei.com
Subject: Re: hrtimer become inaccurate with RT patch
Date: Mon, 2 Jul 2018 12:14:21 +0200 [thread overview]
Message-ID: <20180702101420.rskzwqrdyws5fl6m@breakpoint.cc> (raw)
In-Reply-To: <43d78927-3955-acde-a2d1-d2b82932a7a6@huawei.com>
On 2018-07-02 17:34:34 [+0800], gengdongjiu wrote:
> The Linux kernel version is v4.1.46, and the preempt_rt patch is
> patch-4.1.46-rt52.patch.
the 4.1 series is no longer supported (neither RT wise nor non-RT,
https://www.kernel.org/category/releases.html). I suggest to move away.
If you notice this problem now it is hardly a long running project.
> process will not be interrupt. But if the hrtimer is also runs in
> process context the timer is useless when it's inaccurate. so I want to
> consult you whether this is expected behavior? whether is reasonable to move the timer IRQ
> handling to a thread?
This depends on your expectations. The timer is defined not to fire
before the programmed time. So it fires as soon as possible _after_ the
programmed time.
> I think this is why hrtimer is run as a thread, I tried to set
> hrtimer.irqsafe to 1, but the timer still seemed not right. Could anyone
> give some advise? Thanks.
By setting irqsafe to 1 you ensure taht the timer will fire from the
timer interrupt and before doing so you should ensure that the timer is
indeed IRQ safe.
Depending on what you do it is possible that the timer fires early but
the application notices it later (the scheduler will first handle RT
tasks according to their priorities followed by non RT tasks).
Sebastian
next prev parent reply other threads:[~2018-07-02 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12e6da4e-7681-771f-38d3-3c1abf943c24@huawei.com>
2018-07-02 9:34 ` gengdongjiu
2018-07-02 10:14 ` Sebastian Andrzej Siewior [this message]
2018-07-02 11:19 ` gengdongjiu
2018-07-02 19:38 ` Sebastian Andrzej Siewior
2018-07-06 14:22 ` Daniel Wagner
2018-07-06 14:30 ` Sebastian Andrzej Siewior
2018-07-02 19:25 ` John Stultz
2018-07-02 20:13 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702101420.rskzwqrdyws5fl6m@breakpoint.cc \
--to=bigeasy@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=gengdongjiu@huawei.com \
--cc=hangaohuai@huawei.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=liupeifeng3@huawei.com \
--cc=tglx@linutronix.de \
--cc=yangchuanlong@huawei.com \
--cc=zhangbin46@huawei.com \
--cc=zhangjianwei8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®