From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5433FC6778A for ; Mon, 2 Jul 2018 10:22:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1440A25C62 for ; Mon, 2 Jul 2018 10:22:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1440A25C62 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965559AbeGBKWo (ORCPT ); Mon, 2 Jul 2018 06:22:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:38266 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965541AbeGBKWj (ORCPT ); Mon, 2 Jul 2018 06:22:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9C68AACCE; Mon, 2 Jul 2018 10:22:37 +0000 (UTC) Date: Mon, 2 Jul 2018 12:22:36 +0200 From: Michal Hocko To: ufo19890607@gmail.com Cc: akpm@linux-foundation.org, rientjes@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp, guro@fb.com, yang.s@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yuzhoujian@didichuxing.com Subject: Re: [PATCH v11 2/2] Add the missing information in dump_header Message-ID: <20180702102236.GE19043@dhcp22.suse.cz> References: <1530376739-20459-1-git-send-email-ufo19890607@gmail.com> <1530376739-20459-2-git-send-email-ufo19890607@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1530376739-20459-2-git-send-email-ufo19890607@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 01-07-18 00:38:59, ufo19890607@gmail.com wrote: > From: yuzhoujian > > Add a new func mem_cgroup_print_oom_context to print missing information > for the system-wide oom report which includes the oom memcg that has > reached its limit, task memcg that contains the killed task. A proper changelog should contain the motivation. It is trivial to see what the patch does from the diff. The motivation is less clear. What about the followig " The current oom report doesn't display victim's memcg context during the global OOM situation. While this information is not strictly needed it can be really usefule for containerized environments to see which container has lost a process (+ add more arguments I am just guessing from your not really specific statements). Now that we have a single line for the oom context we can trivially add both the oom memcg (this can be either global_oom or a specific memcg which hits its hard limits) and task_memcg which is the victim's memcg. " -- Michal Hocko SUSE Labs