From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5546C3279B for ; Mon, 2 Jul 2018 15:41:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AA4D24FC7 for ; Mon, 2 Jul 2018 15:41:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AA4D24FC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752721AbeGBPlP (ORCPT ); Mon, 2 Jul 2018 11:41:15 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:58608 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752282AbeGBPlO (ORCPT ); Mon, 2 Jul 2018 11:41:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47B5477885; Mon, 2 Jul 2018 15:41:13 +0000 (UTC) Received: from gondolin (ovpn-117-51.ams2.redhat.com [10.36.117.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61D28111AF34; Mon, 2 Jul 2018 15:41:06 +0000 (UTC) Date: Mon, 2 Jul 2018 17:41:03 +0200 From: Cornelia Huck To: Tony Krowiak Cc: Christian Borntraeger , Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com Subject: Re: [PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization Message-ID: <20180702174103.5d1ce603.cohuck@redhat.com> In-Reply-To: <276b5ae7-7f27-faae-1e5a-0d4c084139e9@linux.ibm.com> References: <1530306683-7270-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1530306683-7270-6-git-send-email-akrowiak@linux.vnet.ibm.com> <276b5ae7-7f27-faae-1e5a-0d4c084139e9@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 02 Jul 2018 15:41:13 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 02 Jul 2018 15:41:13 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Jul 2018 11:37:11 -0400 Tony Krowiak wrote: > On 07/02/2018 10:38 AM, Christian Borntraeger wrote: > > > > On 06/29/2018 11:11 PM, Tony Krowiak wrote: > >> Introduces a new CPU model feature and two CPU model > >> facilities to support AP virtualization for KVM guests. > >> > >> CPU model feature: > >> > >> The KVM_S390_VM_CPU_FEAT_AP feature indicates that > >> AP instructions are available on the guest. This > >> feature will be enabled by the kernel only if the AP > >> instructions are installed on the linux host. This feature > >> must be specifically turned on for the KVM guest from > >> userspace to use the VFIO AP device driver for guest > >> access to AP devices. > >> > >> CPU model facilities: > >> > >> 1. AP Query Configuration Information (QCI) facility is installed. > >> > >> This is indicated by setting facilities bit 12 for > >> the guest. The kernel will not enable this facility > >> for the guest if it is not set on the host. This facility > >> must not be set by userspace if the KVM_S390_VM_CPU_FEAT_AP > >> feature is not installed. > >> > >> If this facility is not set for the KVM guest, then only > >> APQNs with an APQI less than 16 will be available to the > >> guest regardless of the guest's matrix configuration. This > >> is a limitation of the AP bus running on the guest. > >> > >> 2. AP Facilities Test facility (APFT) is installed. > >> > >> This is indicated by setting facilities bit 15 for > >> the guest. The kernel will not enable this facility for > >> the guest if it is not set on the host. This facility > >> must not be set by userspace if the KVM_S390_VM_CPU_FEAT_AP > >> feature is not installed. > >> > >> If this facility is not set for the KVM guest, then no > >> AP devices will be available to the guest regardless of > >> the guest's matrix configuration. This is a limitation > >> of the AP bus running under the guest. > >> > >> Reviewed-by: Christian Borntraeger > >> Reviewed-by: Halil Pasic > >> Signed-off-by: Tony Krowiak > > I think it probably should be at the end of the series, other than that its good. > > If I move this to the end of the series, the very next patch checks the > > KVM_S390_VM_CPU_FEAT_AP feature? Introduce it here, offer it only with the last patch?