From: Michal Hocko <mhocko@kernel.org>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, linux-mm@kvack.org,
mgorman@techsingularity.net, gregkh@linuxfoundation.org
Subject: Re: [PATCH v2] mm: teach dump_page() to correctly output poisoned struct pages
Date: Mon, 2 Jul 2018 20:56:12 +0200 [thread overview]
Message-ID: <20180702185612.GJ19043@dhcp22.suse.cz> (raw)
In-Reply-To: <20180702180536.2552-1-pasha.tatashin@oracle.com>
On Mon 02-07-18 14:05:36, Pavel Tatashin wrote:
[...]
> void __dump_page(struct page *page, const char *reason)
> {
> + bool page_poisoned = PagePoisoned(page);
> + int mapcount;
> +
> + /*
> + * If struct page is poisoned don't access Page*() functions as that
> + * leads to recursive loop. Page*() check for poisoned pages, and calls
> + * dump_page() when detected.
> + */
> + if (page_poisoned) {
> + pr_emerg("page:%px is uninitialized and poisoned", page);
> + goto hex_only;
> + }
Thanks for the updated comment. Exactly what I was looking for!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-02 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 18:05 Pavel Tatashin
2018-07-02 18:56 ` Michal Hocko [this message]
2018-07-02 19:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702185612.GJ19043@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=pasha.tatashin@oracle.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®