From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Whitmore <johnfwhitmore@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
insafonov@gmail.com, gregkh@linuxfoundation.org,
baijiaju1990@gmail.com, joe@perches.com,
colin.king@canonical.com, keescook@chromium.org
Subject: Re: [PATCH 5/5] staging: rtl8192u: Refactor for coding style
Date: Wed, 4 Jul 2018 15:26:07 +0300 [thread overview]
Message-ID: <20180704122607.joini6yhhdprfslg@mwanda> (raw)
In-Reply-To: <20180704115925.28024-5-johnfwhitmore@gmail.com>
On Wed, Jul 04, 2018 at 12:59:25PM +0100, John Whitmore wrote:
> Changes to indentation and witespace issues in the ieee80211_softmac.c file.
>
You're doing too much stuff in one patch.
regards,
dan carpenter
prev parent reply other threads:[~2018-07-04 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 11:59 [PATCH 1/5] staging: rtl8192u: Use __func__ instead of hardcoded string - Style John Whitmore
2018-07-04 11:59 ` [PATCH 2/5] staging: rtl8192u: Use memset to initialize memory, instead of loop John Whitmore
2018-07-04 11:59 ` [PATCH 3/5] staging: rtl8192u: Remove unused variable John Whitmore
2018-07-04 12:18 ` Dan Carpenter
2018-07-04 11:59 ` [PATCH 4/5] staging: rtl8192u: Remove redundant definitions in header John Whitmore
2018-07-04 11:59 ` [PATCH 5/5] staging: rtl8192u: Refactor for coding style John Whitmore
2018-07-04 12:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704122607.joini6yhhdprfslg@mwanda \
--to=dan.carpenter@oracle.com \
--cc=baijiaju1990@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=joe@perches.com \
--cc=johnfwhitmore@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®