mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Tobias Tefke <tobias.tefke@gmail.com>
Cc: tobias.tefke@tutanota.com, peterz@infradead.org,
	mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: events: use correct articles in comments
Date: Thu, 5 Jul 2018 13:27:50 +0100	[thread overview]
Message-ID: <20180705122750.2vsgjy35cfri2665@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20180705122608.h7j5wo7wd4ndw2jm@lakrids.cambridge.arm.com>

On Thu, Jul 05, 2018 at 01:26:08PM +0100, Mark Rutland wrote:
> On Thu, Jul 05, 2018 at 01:27:56PM +0200, Tobias Tefke wrote:
> > These words are pronounced (and start) with a vowel sound.
> > Therefore the article we use has to be 'an' instead of 'a'.
> > 
> > Signed-off-by: Tobias Tefke <tobias.tefke@tutanota.com>
> 
> To clarify Alexander's reply, there's some guidance on writing commit
> messages in section 2 of:
> 
> Documentation/process/submitting-patches.rst
> 
> The basic idea is that the commit message should make sense on its own,
> even if you can't see the diff. Describe the problem first, any
> caveats, then the solution taken (in the imperative tense).
> 
> e.g. the above could be:
> 
> ----
> Some of the comments in the kernel events code use articles incorrectly,
> 'a' for words beginning with a vowel sound, where 'an' should be used.

Whoops, dropped a word here. That should say:

Some of the comments in the kernel events code use articles incorrectly,
using 'a' for words beginning with a vowel sound, where 'an' should be
used.

Mark.

      reply	other threads:[~2018-07-05 12:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 11:27 Tobias Tefke
2018-07-05 11:45 ` Alexander Shishkin
2018-07-05 12:26 ` Mark Rutland
2018-07-05 12:27   ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705122750.2vsgjy35cfri2665@lakrids.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tobias.tefke@gmail.com \
    --cc=tobias.tefke@tutanota.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®