From: Andrew Morton <akpm@linux-foundation.org>
To: "Tian, Baofeng" <baofeng.tian@intel.com>
Cc: "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhuang, Qihua" <qihua.zhuang@intel.com>
Subject: Re: [PATCH] reboot: add reboot_panic parameter
Date: Thu, 5 Jul 2018 14:54:18 -0700 [thread overview]
Message-ID: <20180705145418.67fbcebca351c2d1142f3475@linux-foundation.org> (raw)
In-Reply-To: <EEBA739CCF11FE49B73E1FB4690F5EE649E29D75@SHSMSX101.ccr.corp.intel.com>
On Thu, 5 Jul 2018 06:47:37 +0000 "Tian, Baofeng" <baofeng.tian@intel.com> wrote:
> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Tuesday, July 3, 2018 5:31 AM
> To: Tian, Baofeng <baofeng.tian@intel.com>
> Cc: andrew.smirnov@gmail.com; linux-kernel@vger.kernel.org; Zhuang, Qihua <qihua.zhuang@intel.com>
> Subject: Re: [PATCH] reboot: add reboot_panic parameter
>
> On Mon, 2 Jul 2018 02:20:59 +0000 "Tian, Baofeng" <baofeng.tian@intel.com> wrote:
>
> > This "reboot_panic" kernel cmdline parameter allow to change the
> > reboot mode in case of panic only. It use the same format as the
> > "reboot" parameter.
> > Example, for cf9 warm reset in case of panic: reboot_panic=p,w
> > currently it only support cold/warm reset in case of panic.
>
> Why should we do this? What are the benefits, what are the usecases, etc?
>
> Some user-facing documentation should clear that up. `grep -r reboot= Documentation' will direct you to the appropriate places.
>
(top-posting repaired. Please don't top-post)
> Hi, Morton
"Andrew" :)
> On android platform, if use adb reboot, it will automatically reboot with cold reset.
> cold reset will reset RAM and cause RAM lose data information, if we want to enable some debug features
> like pstore, and ramdump etc, warm reset is needed to keep RAM across reset
>
> So, we add this interface to allow people to set reboot as warm to get log data across reset.
>
OK, sounds good. Please add this info to the changelog, add the user
documentation and resend.
prev parent reply other threads:[~2018-07-05 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0038B620BAC72941BCBF48AEB892976C02CADD8C@shsmsx102.ccr.corp.intel.com>
[not found] ` <EEBA739CCF11FE49B73E1FB4690F5EE649E1B93B@shsmsx102.ccr.corp.intel.com>
2018-07-02 21:30 ` Andrew Morton
2018-07-05 6:47 ` Tian, Baofeng
2018-07-05 21:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705145418.67fbcebca351c2d1142f3475@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrew.smirnov@gmail.com \
--cc=baofeng.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qihua.zhuang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®