mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, peterz@infradead.org,
	will.deacon@arm.com
Cc: andy.shevchenko@gmail.com, arnd@arndb.de,
	aryabinin@virtuozzo.com, boqun.feng@gmail.com,
	catalin.marinas@arm.com, dvyukov@google.com, glider@google.com,
	hpa@zytor.com, linuxdrivers@attotech.com, mark.rutland@arm.com,
	mingo@kernel.org, mingo@redhat.com, parri.andrea@gmail.com,
	peter@hurleysoftware.com, tglx@linutronix.de
Subject: [PATCHv3 02/12] atomics/x86: reduce arch_cmpxchg64*() instrumentation
Date: Thu,  5 Jul 2018 17:40:43 +0100	[thread overview]
Message-ID: <20180705164053.10073-3-mark.rutland@arm.com> (raw)
In-Reply-To: <20180705164053.10073-1-mark.rutland@arm.com>

Currently x86's arch_cmpxchg64() and arch_cmpxchg64_local() are
instrumented twice, as they call into instrumented atomics rather than
their arch_ equivalents.

A call to cmpxchg64() results in:

  cmpxchg64()
    kasan_check_write()
    arch_cmpxchg64()
      cmpxchg()
        kasan_check_write()
        arch_cmpxchg()

Let's fix this up and call the arch_ equivalents, resulting in:

  cmpxchg64()
    kasan_check_write()
    arch_cmpxchg64()
      arch_cmpxchg()

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will.deacon@arm.com>
---
 arch/x86/include/asm/cmpxchg_64.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/cmpxchg_64.h b/arch/x86/include/asm/cmpxchg_64.h
index bfca3b346c74..072e5459fe2f 100644
--- a/arch/x86/include/asm/cmpxchg_64.h
+++ b/arch/x86/include/asm/cmpxchg_64.h
@@ -10,13 +10,13 @@ static inline void set_64bit(volatile u64 *ptr, u64 val)
 #define arch_cmpxchg64(ptr, o, n)					\
 ({									\
 	BUILD_BUG_ON(sizeof(*(ptr)) != 8);				\
-	cmpxchg((ptr), (o), (n));					\
+	arch_cmpxchg((ptr), (o), (n));					\
 })
 
 #define arch_cmpxchg64_local(ptr, o, n)					\
 ({									\
 	BUILD_BUG_ON(sizeof(*(ptr)) != 8);				\
-	cmpxchg_local((ptr), (o), (n));					\
+	arch_cmpxchg_local((ptr), (o), (n));				\
 })
 
 #define system_has_cmpxchg_double() boot_cpu_has(X86_FEATURE_CX16)
-- 
2.11.0


  parent reply	other threads:[~2018-07-05 16:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 16:40 [PATCHv3 00/12] atomics: generate atomic headers / instrument arm64 Mark Rutland
2018-07-05 16:40 ` [PATCHv3 01/12] atomic/tty: Fix up atomic abuse in ldsem Mark Rutland
2018-07-05 16:40 ` Mark Rutland [this message]
2018-07-05 16:40 ` [PATCHv3 03/12] atomics: simplify cmpxchg() instrumentation Mark Rutland
2018-07-05 16:40 ` [PATCHv3 04/12] atomics/treewide: instrument xchg() Mark Rutland
2018-07-05 16:40 ` [PATCHv3 05/12] atomics: instrument cmpxchg_double*() Mark Rutland
2018-07-05 16:40 ` [PATCHv3 06/12] atomics/treewide: rework ordering barriers Mark Rutland
2018-07-05 16:40 ` [PATCHv3 07/12] atomics: add common header generation files Mark Rutland
2018-07-05 16:40 ` [PATCHv3 08/12] atomics: switch to generated fallbacks Mark Rutland
2018-07-05 17:23   ` Peter Zijlstra
2018-07-06  5:51     ` Mark Rutland
2018-07-05 16:40 ` [PATCHv3 09/12] atomics: switch to generated atomic-long Mark Rutland
2018-07-05 16:40 ` [PATCHv3 10/12] atomics: switch to generated instrumentation Mark Rutland
2018-07-05 16:40 ` [PATCHv3 11/12] atomics: check generated headers are up-to-date Mark Rutland
2018-07-05 16:40 ` [PATCHv3 12/12] arm64: use instrumented atomics Mark Rutland
2018-07-06 13:16 ` [PATCHv3 00/12] atomics: generate atomic headers / instrument arm64 Will Deacon
2018-07-06 13:21   ` Peter Zijlstra
2018-07-13 15:06     ` Mark Rutland
2018-07-14 13:01       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705164053.10073-3-mark.rutland@arm.com \
    --to=mark.rutland@arm.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=aryabinin@virtuozzo.com \
    --cc=boqun.feng@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=hpa@zytor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxdrivers@attotech.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=parri.andrea@gmail.com \
    --cc=peter@hurleysoftware.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®