mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Petr Mladek <pmladek@suse.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"Tobin C. Harding" <me@tobin.cc>,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: [PATCH] vsprintf: fix build warning
Date: Fri,  6 Jul 2018 15:47:08 +0200	[thread overview]
Message-ID: <20180706134724.563799-1-arnd@arndb.de> (raw)

The have_filled_random_ptr_key variable was recently removed,
but then reappeared with another patch, presumably after an
incorrect rebase:

lib/vsprintf.c:1668:13: error: 'have_filled_random_ptr_key' defined but not used [-Werror=unused-variable]

This removes it again.

Fixes: 85f4f12d5139 ("vsprintf: Replace memory barrier with static_key for random_ptr_key update")
Fixes: bfe80ed3d7c7 ("vsprintf: add command line option debug_boot_weak_hash")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 lib/vsprintf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index cdc2c355dff5..5fe18ac4d37c 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1665,7 +1665,6 @@ static int __init debug_boot_weak_hash_enable(char *str)
 }
 early_param("debug_boot_weak_hash", debug_boot_weak_hash_enable);
 
-static bool have_filled_random_ptr_key __read_mostly;
 static siphash_key_t ptr_key __read_mostly;
 
 static void enable_ptr_key_workfn(struct work_struct *work)
-- 
2.9.0


             reply	other threads:[~2018-07-06 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 13:47 Arnd Bergmann [this message]
2018-07-06 14:42 ` Sergey Senozhatsky
2018-07-06 15:49   ` Steven Rostedt
2018-07-09  9:45     ` Petr Mladek
2018-07-09 23:15     ` Tobin C. Harding
2018-07-09 23:42     ` Tobin C. Harding
2018-07-10  0:05       ` Sergey Senozhatsky
2018-07-10  2:27       ` Steven Rostedt
2018-07-10  2:28       ` valdis.kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180706134724.563799-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®